tlborm icon indicating copy to clipboard operation
tlborm copied to clipboard

metavar explanations are outdated

Open Veykril opened this issue 1 year ago • 4 comments

The counting order has been inversed recently I believe so the metavar section describes most metavars incorrectly now

Veykril avatar May 28 '24 11:05 Veykril

It's kinda odd how it sees it(there's one \n) (playground):

match (&compute_len("its input should somehow be self-referential, so let us make it return some\nninety-one!"),
            &Some(91)) {
        (left_val, right_val) => {
            if !(*left_val == *right_val) {
                    let kind = ::core::panicking::AssertKind::Eq;
                    ::core::panicking::assert_failed(kind, &*left_val,
                        &*right_val, ::core::option::Option::None);
                }
        }
    };

but in code it's

assert_eq!(
        call_a_or_b_on_tail!(
            (a: compute_len, b: show_tail),
            and now, to justify the existence of two paths
            we will also call a: its input should somehow
            be self-referential, so let us make it return
            some ninety-one!
        ),
        Some(91)
    );

correabuscar avatar May 28 '24 12:05 correabuscar

Oh interesting, the failure is not due tothe metavar changes, hmm wonder what changed there then

Veykril avatar May 28 '24 12:05 Veykril

This regressed in rust 1.76, will investigate. Neverheless, the issue here is still applicable, the explanations are outdated since https://github.com/rust-lang/rust/pull/117050

Veykril avatar May 28 '24 12:05 Veykril

Right we are relying on the stringify output here which is not really specified so this is bound to occasionally break

Veykril avatar May 28 '24 12:05 Veykril