Lukas Wirth

Results 738 comments of Lukas Wirth

Ye, we don't catch panics in notification handlers it seems so the server just dies in that case :) I think that's an oversight. Ah no this is intentional

I'd say in this case we should offer ~~both, by~~ - a) ~~if invoked on the `use` statement,~~ replace all occurences - b) ~~if invoked on a usage, replace only...

Yes, and I think for that one it makes more sense to replace all. Honestly I wouldn't mind this one also always replacing all I guess, I don' treally see...

The closest we have to that is probably the `extract_function` assist, but even that isn't too smart about the extraction range yet. Though in this case function boundaries don't really...

Looks like this happens in general after typing `if ` (note the space), similar for `while `. This seems to be an issue with snippets?

If you type out `if` you'll see completions like the following ![image](https://user-images.githubusercontent.com/3757771/174407065-66d890d0-9084-4f81-998b-f179c4cf47ef.png) The `if let` completion there is a snippet (it can set your cursor to a position and pre-select...

Looking into this, this seems to be a bug in VSCode. When ` `(space) is entered it does not re-request the completion list and keeps the old one, then on...

Oh this is a funny one, we parse the block expression, then due to a bug here we consider the expression finished and since its a block there is no...

Interesting, so `const` blocks behave differently from normal blocks and `unsafe` blocks ...