bog icon indicating copy to clipboard operation
bog copied to clipboard

Upgrade for RLS changes

Open Atomk opened this issue 2 years ago • 1 comments

Excluding the first commit (the @min change) everything else is a combination of automatic fixes applied by fmt plus some manual changes - mostly removing @as where not needed. In a couple places @alignOf required some more edits to fix compilation errors due to the new cast builtin changes. Two of these are in multi_array_list.zig.

If you apply zig fmt to bog master branch and diff against my edits, manual corrections will be much easier to spot and review.

I tested the changes with 0.11.0-dev.3890+43c98dc11

Atomk avatar Jun 29 '23 23:06 Atomk

I tried to update this PR to latest master (0.11.0-dev.4203+c57749f5c) and @splat needs to be updated which is a trivial fix, but after that I got an arror related to jsonStringify that looks a bit more complicated:

C:\zig\lib\std\json\stringify.zig:463:37: error: member function expected 2 argument(s), found 1
                        return value.jsonStringify(self);
                               ~~~~~^~~~~~~~~~~~~~
src\value.zig:1075:9: note: function declared here
    pub fn jsonStringify(val: *const Value, options: std.json.StringifyOptions, writer: anytype) @TypeOf(writer).Error!void {
    ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Atomk avatar Jul 25 '23 01:07 Atomk