vets-who-code-app icon indicating copy to clipboard operation
vets-who-code-app copied to clipboard

Ensure Font is Uniform Across Pages

Open Cameron-Porter opened this issue 2 years ago • 2 comments

Describe the bug Ensure font is uniformly applied to the app. It seems it is not fully covering the Apply -> Mentor page.

To Reproduce Steps to reproduce the behavior:

  1. Go to Apply
  2. Click on Mentor
  3. Scroll down to view different fonts displayed on the page

Expected behavior Expect the Gotham font to be applied to as per other pages in the app.

Cameron-Porter avatar Jun 22 '22 12:06 Cameron-Porter

I may be misreading, or need new glasses and cannot tell the difference, but each individual class Inherits from body. When I inspect the page and look at each element the styles has:

body, h1, h2, h3, h4, h5, h6 { font-family: Gotham,sans-serif; }

Takomane avatar Jul 03 '22 18:07 Takomane

@Takomane It does show that, but it's not displaying as such. I had to change the typed.js font by using inline styling.

<Typed
                    style={{ fontFamily: 'Gotham, sans-serif' }}
                    className="typedString"
                    strings={[
                      'RESULTS DRIVEN',
                      '100% ONLINE',
                      'LEARN PRAGMATICALLY',
                      'PREPARED FOR THE INDUSTRY',
                    ]}
                    typeSpeed={70}
                    backSpeed={80}
                    smartBackspace
                    loop
                  />

You can see here that in the podcast headers it's not using the Gotham font. I can't remember, but I think if you have Gotham installed locally it works everywhere as intended so it's not noticeable to everyone.

font

stephanlamoureux avatar Jul 03 '22 19:07 stephanlamoureux