Andrew Bulat comments

Results 96 comments of


                                            Andrew Bulat

feat: listeners api

Some comments before review: Should we add the same for Annotations while we're at it? And callback types seem to mismatch, tests are not happy. Also should discuss if there...

[PUB-1197] LiveObjects REST client

> Something I noticed when testing this branch for Msgpack requests. The SDK currently isn't setting the correct content type header of application/msgpack it was being set to JSON still...

[PUB-1197] LiveObjects REST client

> Can we try running these tests with msgpack to see if it works? I did find this ticket which may indicate an issue with msgpack over rest currently: https://ably.atlassian.net/browse/PUB-1835...

[ERROR] ⨯ EvalError: Code generation from strings disallowed for this context when using Ably with Next.js on Cloudflare

Hello @catpddo ! Sorry for the delay. I looked into this but couldn’t reproduce the `EvalError: Code generation from strings disallowed for this context` error you described, either with Cloudflare...

TypeScript type mismatch for clientId in Realtime options (null vs undefined) (ClientId must be either a string or null)

Hey @ITBoomBKStudio , thank you for reporting this. We can confirm that there is an inconsistency between the TypeScript type definitions and the runtime validation. Both `undefined` and `null` should...

Cannot find module 'ably/promises' or its corresponding type declarations.

Hi @abmercy035 ! Are you using the ably-js v2? If so, starting with version 2, ably-js no longer offers a choice between a callbacks-based API and a promises-based API, and...