very_good_cli icon indicating copy to clipboard operation
very_good_cli copied to clipboard

feat: allow `very_good create .`

Open a-wallen opened this issue 1 year ago โ€ข 8 comments

Status

READY/IN DEVELOPMENT/HOLD READY

Description

Allows . as a project name (like flutter create .)

Type of Change

  • [x] โœจ New feature (non-breaking change which adds functionality)
  • [ ] ๐Ÿ› ๏ธ Bug fix (non-breaking change which fixes an issue)
  • [ ] โŒ Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] ๐Ÿงน Code refactor
  • [ ] โœ… Build configuration change
  • [ ] ๐Ÿ“ Documentation
  • [ ] ๐Ÿ—‘๏ธ Chore

a-wallen avatar Mar 19 '24 07:03 a-wallen

fixes https://github.com/VeryGoodOpenSource/very_good_cli/issues/969

a-wallen avatar Mar 19 '24 07:03 a-wallen

this is ready for review.

by the way, the repo had 37 broken tests when I cloned it on my machine. I was wondering if I should submit those as issues.

a-wallen avatar Mar 19 '24 19:03 a-wallen

Fixed the formatting issue by updating from main via #1003 so CI is now passing. @wolfenrain can we get a review here?

tomarra avatar Mar 27 '24 13:03 tomarra

Pinging @wolfenrain

alestiago avatar Aug 13 '24 10:08 alestiago

sure thing, let me know if there's anything I need to do.

a-wallen avatar Sep 30 '24 23:09 a-wallen

sure thing, let me know if there's anything I need to do.

The CI seems to be failing on some tests, mind having a look at that? I suspect that the tests are failing because of wrong parameters (might mean it isnt backwards compatible like we hoped?)

wolfenrain avatar Oct 07 '24 06:10 wolfenrain

I can't tell which tests are failing. See this issue for more details https://github.com/VeryGoodOpenSource/very_good_cli/issues/1162

a-wallen avatar Oct 09 '24 17:10 a-wallen

I can't tell which tests are failing. See this issue for more details #1162

Take a look at the details of the Actions output here. You can see the failing tests in the output.

tomarra avatar Oct 10 '24 16:10 tomarra