very_good_cli icon indicating copy to clipboard operation
very_good_cli copied to clipboard

feat(test): add --reporter to output in JSON

Open jackgllghr opened this issue 2 years ago โ€ข 1 comments

Description

Added the --reporter flag in the test command, to allow the user to output the test results in JSON. This change simply passes through the command and disables logging when outputting to JSON

Type of Change

  • [x] โœจ New feature (non-breaking change which adds functionality)
  • [ ] ๐Ÿ› ๏ธ Bug fix (non-breaking change which fixes an issue)
  • [ ] โŒ Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] ๐Ÿงน Code refactor
  • [ ] โœ… Build configuration change
  • [ ] ๐Ÿ“ Documentation
  • [ ] ๐Ÿ—‘๏ธ Chore

jackgllghr avatar Jul 28 '22 16:07 jackgllghr

I'm not sure if it makes more sense to the use --machine arg or --reporter arg, I just tried to stick to the original flutter command.

I'm having some issues running the tests in my local environment, some tests I haven't gone near are failing so apologies in advance if I missed something glaring

jackgllghr avatar Jul 28 '22 17:07 jackgllghr

Hi! any news on this PR? I would also need it to get a JSON report for my pipeline....

Thelm76 avatar Nov 02 '22 13:11 Thelm76

@felangel, @jackgllghr is this PR dead? Sorry if I'm beeing to insistent...

Thelm76 avatar Dec 20 '22 15:12 Thelm76

@felangel, @jackgllghr is this PR dead? Sorry if I'm beeing to insistent...

It's not dead but the changes included in this PR are not sufficient so additional work needs to be done to get this to a mergable state.

felangel avatar Dec 20 '22 15:12 felangel

My apologies, the project I required this for got cancelled so my focus wavered. I might get a chance to look at this over the Xmas break, but if someone wants to jump in and finish it off, go for it

jackgllghr avatar Dec 20 '22 16:12 jackgllghr

My apologies, the project I required this for got cancelled so my focus wavered. I might get a chance to look at this over the Xmas break, but if someone wants to jump in and finish it off, go for it

No problem at all! I'm going to close the PR for now but feel free to reopen it if you have time to revisit this, thanks!

felangel avatar Jan 03 '23 19:01 felangel