very_good_cli icon indicating copy to clipboard operation
very_good_cli copied to clipboard

chore: ensure maximum Pana score is reached

Open alestiago opened this issue 9 months ago • 7 comments

Description

The Pana score has dropped to 150/160 in https://github.com/VeryGoodOpenSource/very_good_cli/actions/runs/13943959245/job/39026770951?pr=1217.

We should investigate and attempt to have the highest score.

Requirements

  • [ ] Achieve maximum PANA score

Additional Context

No response

alestiago avatar Mar 19 '25 10:03 alestiago

Labelling as a P1 since it is blocking #1217, which blocks all other incoming PRs.

alestiago avatar Mar 19 '25 10:03 alestiago

Running locally, the score drop is on:

## ✗ Support up-to-date dependencies (30 / 40)
### [x] 0/10 points: All of the package dependencies are supported in the latest version

alestiago avatar Mar 19 '25 10:03 alestiago

Bumping pana to 0.22.20 resolves, made changes at #1217.

alestiago avatar Mar 19 '25 10:03 alestiago

Will be resolved by #1217

alestiago avatar Mar 19 '25 10:03 alestiago

still not solved by #1286 but I'll look into this since we still have 150/160 points for pub score

marcossevilla avatar Jun 13 '25 13:06 marcossevilla

I think the issue we saw at https://github.com/VeryGoodOpenSource/very_good_cli/actions/runs/15630293835/job/44032820732 was regarding formatting not "All of the package dependencies are supported in the latest version", which is interesting.

alestiago avatar Jun 13 '25 14:06 alestiago

There is an issue in PANA which looks like it's affecting us: https://github.com/dart-lang/pana/issues/1459

alestiago avatar Jun 21 '25 20:06 alestiago

this is fixed by #1296

marcossevilla avatar Jun 30 '25 12:06 marcossevilla