very_good_cli icon indicating copy to clipboard operation
very_good_cli copied to clipboard

fix: file-report disables optimization

Open DFelten opened this issue 1 year ago • 5 comments

Description

It is now possible to start the tests with an output as mentioned here. But when running a test with very_good and the file-reporter parameter, the parameter for optimization is no longer working.

Steps To Reproduce

Run test via

very_good test --optimization --coverage -- --file-reporter json:test_reports/dd_test_report.json

No test optimization appears in the terminal and the test needs four times as long. The .test_optimizer.dart file is not generated while the test is running.

Expected Behavior

The test should run with optimization and create a report.

Screenshots

CleanShot 2024-04-05 at 09 59 04@2x

DFelten avatar Apr 05 '24 08:04 DFelten

Hi @DFelten ! Thank you for opening an issue sorry for the late reply, I've haven't been able to catch-up lately.

I've been able to reproduce this in the latest very_good_cli (0.21.0). @DFelten are you interested in contributing?

alestiago avatar May 16 '24 15:05 alestiago

Hi @DFelten, any update or an idea/tip how to solve the problem?

robsonsilv4 avatar Jul 11 '24 12:07 robsonsilv4

Hi @DFelten, any update or an idea/tip how to solve the problem?

I haven't found a workaround, so the problem still exists. Unfortunately, I have no idea how I can solve the problem myself.

DFelten avatar Jul 11 '24 15:07 DFelten

Hi,

I'm experiencing the same issue described in this thread. When I run the command with --optimization and --file-reporter, the optimization is not applied, and the test execution time increases significantly. Additionally, the .test_optimizer.dart file is not generated during the test. I'm using very_good_cli 0.21.0.

I would like to know if there is any temporary workaround or if I can help in any way to contribute to the resolution of this issue.

Thank you in advance for your

Skisperd avatar Aug 09 '24 20:08 Skisperd

Hi all, I'll try raising this within the team and see if it can get prioritised.


If any of you would like to contribute and have questions we're willing to help out and get your PR landed (let me know and I'll assign you to the issue).

In terms of resources, the CONTRIBUTING is a good place to start. Test optimisation relies internally on mason so knowledge with such tool might also help.

alestiago avatar Aug 13 '24 09:08 alestiago