VeryGoodOpenSource
async validation support
Description
I've added code to support async form validations.
Type of Change
- [x] ✨ New feature (non-breaking change which adds functionality)
- [ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
- [ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
- [ ] 🧹 Code refactor
- [ ] ✅ Build configuration change
- [x] 📝 Documentation
- [ ] 🗑️ Chore
@felangel @jorgecoca @renancaraujo @wolfenrain
Sorry for the delay! I’ll have a look shortly 👍
Friendly reminder :)
Another friendly reminder :) @felangel @jorgecoca @renancaraujo @wolfenrain
Would really appreciate it if one of you guys could free up some time to look at this PR and let me know if you agree or reject the change. Then I can focus again on getting the ugly temporary package out of my project..
Hi @jopmiddelkamp, sorry for the delay we will try to get to it this week!
For now i'll at least run the workflows to validate if it also succeeds :D
Hi @jopmiddelkamp, sorry for the delay we will try to get to it this week!
For now i'll at least run the workflows to validate if it also succeeds :D
Thanks/bedankt @wolferain!
Hello @jopmiddelkamp, Thanks for all that effort, and forgive us for the huge delay in responding 🙏🏽.
After looking into the code and having a conversation with the team, we decided that async validation has use cases that may need a more careful look into. So we won't merge this. Also, I left some more comments below with feedback on some points we noticed with your approach.
Thanks again for your contribution!
@renancaraujo could this PR be taken as a base for a new one? Or better raise a new PR having this proposal in mind?
@gugadev yeah, this is still on our backlog of things to do. The specifics of this pr (including the things exposed by comments) for sure will be base for the implementation.
@renancaraujo I have made this one https://github.com/VeryGoodOpenSource/formz/pull/93 as a initial setup to bring back to discussion if using FutureOr as mentioned by https://github.com/VeryGoodOpenSource/formz/issues/15#issuecomment-1134691056 is a good idea. I would appreciate more thoughts on how we can do the async validation. If we want to have FutureOr at the FormzInput abstract class we would force who is just using sync validators to use the await keyword as you can see at my initial PR.
