flutter_web_preloader
flutter_web_preloader copied to clipboard
refactor: use the `fetch` API
Status
READY
Description
Rewrote it all! :)
In more seriousness:
- Uses the fetch API uniformly.
- Adds a new use of await and removes a usage of async. Neither should actually affect the behavior.
- Moved some code's scope to make it cleaner.
Probably review one-commit-at-a-time?
Closes: #32
Type of Change
- [ ] โจ New feature (non-breaking change which adds functionality)
- [ ] ๐ ๏ธ Bug fix (non-breaking change which fixes an issue)
- [ ] โ Breaking change (fix or feature that would cause existing functionality to change)
- [x] ๐งน Code refactor
- [ ] โ Build configuration change
- [ ] ๐ Documentation
- [ ] ๐๏ธ Chore
Oh, another thing is that this is in sloppy mode, probably worth adding a "use strict" directive.
I don't particularly want to file another PR, but if y'all want to keep this small(er), I don't mind if y'all add it yourselves.
Oh, another thing is that this is in sloppy mode, probably worth adding a
"use strict"directive. I don't particularly want to file another PR, but if y'all want to keep this small(er), I don't mind if y'all add it yourselves.
I am not against adding that here directly, afaik it is just a one-liner right?