ByteTrack-cpp icon indicating copy to clipboard operation
ByteTrack-cpp copied to clipboard

CMake include path issue

Open derpda opened this issue 3 years ago • 3 comments

Once again thank you for putting this together, and for reacting to the issues/PRs so quickly.

Issue

When using this library through

FetchContent_Declare(ByteTrackCpp
  GIT_REPOSITORY  https://github.com/Vertical-Beach/ByteTrack-cpp.git
  GIT_TAG         main
  GIT_SHALLOW     ON)
FetchContent_MakeAvailable(ByteTrackCpp)
# ...
target_link_libraries(my_lib bytetrack)

in my project, the include paths needed for the bytetrack library are not forwarded. Checking a bit further,

get_target_property(bytetrack_INCLUDE_DIRS bytetrack INTERFACE_INCLUDE_DIRECTORIES)
message(STATUS "ByteTrack include dirs: ${bytetrack_INCLUDE_DIRS}")

shows that INTERFACE_INCLUDE_DIRECTORIES are not set.

I will open another small PR fixing this once the current one is merged!

derpda avatar Jul 12 '22 05:07 derpda

~~Thanks! No problem, I have merged it.~~

medalotte avatar Sep 01 '22 12:09 medalotte

I made a mistake on the issue to close.

medalotte avatar Sep 01 '22 12:09 medalotte

Thank you for getting back to me =) I think this issue is fixed with PR #10! As mentioned in the PR, I have since made a host of other changes, if you are interested I can post PRs for those.

derpda avatar Sep 05 '22 06:09 derpda