modeldb icon indicating copy to clipboard operation
modeldb copied to clipboard

chore: [VUMM-392] Add InternalFuture with default Executor

Open liam-verta opened this issue 3 years ago • 1 comments

Impact and Context

This change adds an implementation of InternalFuture that keeps the same executor across method calls rather than passing it to every call.

Risks and Area of Effect

Testing

How to Revert

liam-verta avatar Aug 12 '22 22:08 liam-verta

This is looking pretty good. I'd add some unit tests for the new functionality. I'm not 100% sure how to verify that the proper executor is being used... maybe with some custom executor implementation? Would definitely at the very least add tests to verify that things work (we have needed these tests for a long time now), and that a null executor makes things fail fast.

jkwatson-verta avatar Aug 15 '22 15:08 jkwatson-verta