saml2aws icon indicating copy to clipboard operation
saml2aws copied to clipboard

Use the same output for surveys as for logs.

Open jkinkead opened this issue 2 years ago • 1 comments

Add a package variable to hold the survey output writer and a setter for it.

Add a helper to generate a survey option using the writer for stdout.

Initialize the survey output to be the same as for the log module.


Fixes #883 .

jkinkead avatar Sep 05 '22 22:09 jkinkead

One thing I forgot to note: The survey library can't just query log.Writer because it requires a special type that include a file descriptor, and there is no way to get an fd from log.

jkinkead avatar Sep 07 '22 23:09 jkinkead

Codecov Report

Merging #884 (959bc67) into master (7cc41b5) will decrease coverage by 0.02%. The diff coverage is 0.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
- Coverage   39.11%   39.09%   -0.02%     
==========================================
  Files          53       53              
  Lines        7973     7977       +4     
==========================================
  Hits         3119     3119              
- Misses       4440     4444       +4     
  Partials      414      414              
Flag Coverage Δ
unittests 39.09% <0.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/prompter/survey.go 3.12% <0.00%> (-0.21%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Mar 29 '23 00:03 codecov-commenter

Any chance this can be worked on? We need parity with the current test coverage to merge

@jkinkead

mapkon avatar Jun 24 '23 12:06 mapkon