saml2aws icon indicating copy to clipboard operation
saml2aws copied to clipboard

Published 20 hours ago • verified publisher icon Versent

AWS partitions support for `saml2aws console`

Open duckfez opened this issue 4 years ago • 5 comments

Fixes #533.

Adds support for saml2aws console to use region= in config file as a hint for which partition to open the console in.

duckfez avatar Sep 13 '20 01:09 duckfez

I am a little concerned about littering the codebase with special cases for GovCloud and AWS China. But, I don't have the experience with the codebase (or golang itself tbh) to attempt a more comprehensive refactor.

duckfez avatar Sep 13 '20 01:09 duckfez

Okta provider already has special cases https://github.com/Versent/saml2aws/blob/1c3449a189500cee2a110d208fc5c76afa324bb2/pkg/provider/okta/okta.go#L652-L654

gliptak avatar Apr 03 '23 00:04 gliptak

I don't mind rebasing this against current main, but I no longer have access to test in GovCloud. The underlying issue #533 has not seen a lot of support for this problem, so maybe it's not worth it? Maybe one of the other interested folks in that issue can help with testing?

duckfez avatar Apr 03 '23 03:04 duckfez

I don't mind rebasing this against current main, but I no longer have access to test in GovCloud. The underlying issue #533 has not seen a lot of support for this problem, so maybe it's not worth it? Maybe one of the other interested folks in that issue can help with testing?

Thanks for the response! Let us start by rebasing it to main.

mapkon avatar Apr 03 '23 03:04 mapkon

@duckfez Any traction on this?

mapkon avatar Oct 30 '23 06:10 mapkon