saml2aws icon indicating copy to clipboard operation
saml2aws copied to clipboard

Segmentation fault on Macbook M2

Open mehtaruchir opened this issue 2 years ago • 11 comments

getting below error for saml2aws -a login command - specifically for macbook M2 , it works on intel x86 macbook

panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x2 addr=0x60 pc=0x1050428d8]

goroutine 1 [running]: github.com/versent/saml2aws/v2/pkg/provider/browser.glob..func1({0x105720c98, 0x14000654000}, 0x1400012e4d0) github.com/versent/saml2aws/v2/pkg/provider/browser/browser.go:98 +0x1b8 github.com/versent/saml2aws/v2/pkg/provider/browser.(*Client).Authenticate(0x140000b0840, 0x1400012e4d0) github.com/versent/saml2aws/v2/pkg/provider/browser/browser.go:78 +0x214 github.com/versent/saml2aws/v2/cmd/saml2aws/commands.Login(0x14000020f40) github.com/versent/saml2aws/v2/cmd/saml2aws/commands/login.go:105 +0x458 github.com/versent/saml2aws/v2/cmd/saml2aws/commands.loginRefreshCredentials(0x140001122a0?, 0x0?) github.com/versent/saml2aws/v2/cmd/saml2aws/commands/console.go:105 +0x24 github.com/versent/saml2aws/v2/cmd/saml2aws/commands.loadOrLogin(0x14000022780, 0x0?, 0x140003fa060) github.com/versent/saml2aws/v2/cmd/saml2aws/commands/console.go:83 +0x118 github.com/versent/saml2aws/v2/cmd/saml2aws/commands.Console(0x140003fa060) github.com/versent/saml2aws/v2/cmd/saml2aws/commands/console.go:46 +0x80 main.main() github.com/versent/saml2aws/v2/cmd/saml2aws/main.go:195 +0x6db4

mehtaruchir avatar Oct 10 '23 03:10 mehtaruchir

i found 1 behavior pattern,

now on mac M2 , saml2aws MFA only waits for 30 seconds , if one can not finish the MFA auth from their provider in 30 seconds then we get NIL pointer Segmentation exception.

mehtaruchir avatar Oct 10 '23 14:10 mehtaruchir

Sounds like the same issue I am having on the MacBook M1: https://github.com/Versent/saml2aws/issues/1139

kbarlowgw avatar Oct 13 '23 02:10 kbarlowgw

Same on Framework Laptop 13, doesn't seem to be relative to Apple. I have to be quick to finish the 2FA auth.

arobase-che avatar Oct 16 '23 09:10 arobase-che

It seems to be playwright: https://playwright.dev/docs/api/class-page#page-wait-for-request

I was able to patch it locally: https://github.com/Versent/saml2aws/issues/1139#issuecomment-1761511702

kbarlowgw avatar Oct 16 '23 13:10 kbarlowgw

I am still not able to patch it locally. I tried the steps given in #1139 , also the fix added in the #1153 is still not added in release, 2.36.12 version still has code till #1152 only . any plans for new version release ?

mehtaruchir avatar Nov 02 '23 15:11 mehtaruchir

kbarlowgw -- is it possible to create new release version. 2.36.13 ?

mehtaruchir avatar Nov 06 '23 14:11 mehtaruchir

I don't have the ability to release the project. You need the maintainers to do that.

On Mon, Nov 6, 2023 at 9:16 AM mehtaruchir @.***> wrote:

kbarlowgw https://github.com/kbarlowgw -- is it possible to create new release version. 2.36.13 ?

— Reply to this email directly, view it on GitHub https://github.com/Versent/saml2aws/issues/1142#issuecomment-1794926739, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBG2EVGEMZXO2EFQ3PHMPE3YDDWL3AVCNFSM6AAAAAA5ZU7OOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJUHEZDMNZTHE . You are receiving this because you commented.Message ID: @.***>

kbarlowgw avatar Nov 06 '23 14:11 kbarlowgw

is this fixed in current build? artifacts.zip at bottom of https://github.com/Versent/saml2aws/actions/runs/6855210834?pr=1162

gliptak avatar Nov 14 '23 00:11 gliptak

not able to test this . artifact.zip. unfortunately.

mehtaruchir avatar Nov 16 '23 20:11 mehtaruchir

@mehtaruchir artifact.zip contains platforms specific executables enabling local testing

gliptak avatar Nov 16 '23 22:11 gliptak

kbarlowgw -- is it possible to create new release version. 2.36.13 ?

@mehtaruchir there is currently a new release version. Are you able to see if the new version fixes the issue?

tinaboyce avatar Dec 22 '23 13:12 tinaboyce