JavaVerbalExpressions icon indicating copy to clipboard operation
JavaVerbalExpressions copied to clipboard

Fixing zeroOrMore() and oneOrMore() methods

Open Tavio opened this issue 9 years ago • 3 comments

This is a fix for issue https://github.com/VerbalExpressions/JavaVerbalExpressions/issues/36.

zeroOrMore() and oneOrMore() methods now accept a parameter just like the maybe method() in order to generate correct expressions.

As a temporary side effect, it is no longer possible to do things like regex().digit().zeroOrMore(). I intend to fix this in a future PR.

Tavio avatar Feb 06 '15 17:02 Tavio

Can one of the admins verify this patch?

dummy-lanwen-bot avatar Feb 06 '15 17:02 dummy-lanwen-bot

Coverage Status

Coverage remained the same at 85.89% when pulling 66598f164daef71a421b021908ddcf8377c336a2 on Tavio:fix_one_or_more_zero_or_more into 12533955388db6f9af49da4590b9744de71293fd on VerbalExpressions:master.

coveralls avatar Feb 06 '15 18:02 coveralls

I think implementing of current behaviour can be done in this pr

lanwen avatar Feb 06 '15 23:02 lanwen