Timur Kristóf

icon indicating a website link https://timur.hu/

icon location Budapest, Hungary icon location Currently working on the Linux open source graphics stack, contributing to Mesa, specifically RADV and ACO. Valve contractor.

Results 171 comments of Timur Kristóf

Double free issue when using a cursor

@nwbrad No problem, we can keep this open for a few more weeks. In the meantime if any other user encounters the same or similar issue, they can chime in...

update TypeScript Bindings

Can you indicate in the commit messages that these only affect the TypeScript binding and not the rest of `node-lmdb`? Thanks.

Add equivalents for goToFirst(), goToLast(), goToPrev(), goToNext() and goToRange() which can return also value.

@degifted Thank you for the suggestion! What do you think, what exactly would be the performance benefit of this change?

Add equivalents for goToFirst(), goToLast(), goToPrev(), goToNext() and goToRange() which can return also value.

@degifted What is the array for?

Add equivalents for goToFirst(), goToLast(), goToPrev(), goToNext() and goToRange() which can return also value.

@degifted Ah, so you basically use the array instead of creating an object. I think I get it now. Maybe I can also suggest a better way of doing it.

Add equivalents for goToFirst(), goToLast(), goToPrev(), goToNext() and goToRange() which can return also value.

@degifted Can you give me a performance test which shows the performance advantages of the array approach?

Add equivalents for goToFirst(), goToLast(), goToPrev(), goToNext() and goToRange() which can return also value.

@degifted I'll look into your patches and merge those of them that I think would be useful to others too. > I also added UInt32 key type since existing Number...

Add equivalents for goToFirst(), goToLast(), goToPrev(), goToNext() and goToRange() which can return also value.

@degifted What I meant by the performance test is: can you create a pull request with a test that I can run on my own machine?

Error for " pointer being freed "

Can you please give me a test case with which you can reproduce the problem?

Error for " pointer being freed "

@hanweifish I can't really tell what it is by just looking at that code fragment. Please give me a **full** test case which can reproduce the problem.