Freya Gustavsson comments

Results 314 comments of


                                            Freya Gustavsson

Implementation of streams

You’re right in the complexity issue. I think for our purpose it would be best to implement streams for the most common endpoints. Submissions, comments, and anything that sorts by...

getRandomSubmission() returns Listing of getHot()

Can you run this with `redditAPI.config({debug: true})` and give me the results? Without the output preferably.

getRandomSubmission() returns Listing of getHot()

Seems it will always returns random from front-page. It's still in Reddit API docs and "works" so we will not mark it as deprecated.

getRandomSubmission() returns Listing of getHot()

I see the issue now. I believe that some subreddits have random explicitly disabled for some reason, but I'll investigate further

getRandomSubmission() returns Listing of getHot()

It is a subreddit issue. I cannot say why as I have not found any explanation for it. Some posts on r/redditdev also mention it but give no reason other...

refactor(snoowrap.js): Convert to TypeScript

@markspolakovs I don't suppose you would want to help me out with this one? Converting snoowrap.js to a TS component :sweat_smile:

refactor(snoowrap.js): Convert to TypeScript

I fixed pretty most of the issues, though quite a few remain. There's also quite a bit of `any` and `@ts-ignore`

refactor(snoowrap.js): Convert to TypeScript

Awesome, thank you for the help :)

Implicit calls under the hood, not sure where UnhandledPromiseRejectionWarning

I've not been able to reproduce this as I can't figure out how this could occur in the code-snippet

Revamp test suite to allow for local testing

Sounds good. I would like to see some way of more easily adding tests for instances where one can’t migrate to a mocked server. Only to speed up the process...