Vencord icon indicating copy to clipboard operation
Vencord copied to clipboard

feat(plugin): ChannelTabs

Open sunnniee opened this issue 2 years ago • 57 comments

  • [x] basic functionality
  • [x] notification dots and typing indicators
  • [x] open on certain tabs
    • [x] remember tabs from last session
    • [x] open on a specific set of tabs
  • [x] work fine with account switcher
  • [x] drag and drop for tabs
  • [x] ~~keybinds~~ dropped
  • [x] looks decent on light theme/client themes/basic custom themes
  • [x] fix pin/inbox popout being too tall
  • [x] ctrl click on jump buttons to open in a new tab
    • [x] search results
    • [x] inbox mentions tab
    • [x] inbox unread tab
  • [x] bookmarks
    • [x] adding and deleting
    • [x] editing
    • [x] bookmark folders
      • [x] add bookmarks to folders
      • [x] open bookmarks from folders
      • [x] edit bookmarks within folders
    • [x] drag and drop
    • [x] do something about filled bookmark bars

screenshots

unread and mention indicator, bookmark bar various channel types, light mode, renaming bookmarks client theme, context menu, compact tab, channel emojis

sunnniee avatar Feb 15 '23 17:02 sunnniee

https://github.com/ActuallyTheSun/Vencord/pull/2

nmsturcke avatar Feb 24 '23 19:02 nmsturcke

Customise/Browse Channels/Home is unknown

nmsturcke avatar Feb 24 '23 19:02 nmsturcke

ready for review

sunnniee avatar May 10 '23 12:05 sunnniee

nyaboom

sunnniee avatar May 21 '23 19:05 sunnniee

If there is anything left to be done for this to be merged please lmk :3

keifufu avatar Jun 27 '23 17:06 keifufu

@ActuallyTheSun this is insane, when will this be finished?

VillainsRule avatar Jul 21 '23 23:07 VillainsRule

Hey ! Can you add ping about unread messages in bookmarks tab? image

cryptianm avatar Aug 06 '23 20:08 cryptianm

What needs testing about account switching support?

VillainsRule avatar Aug 06 '23 21:08 VillainsRule

Hey ! Can you add ping about unread messages in bookmarks tab? image

image still can't see ping I updated BookmarkContainer.tsx

cryptianm avatar Aug 07 '23 11:08 cryptianm

Is it possible you can add NotificationDot and Typing indicator functions in the bookmarks?(not only in tabs). It will be a very useful feature image

cryptianm avatar Aug 07 '23 11:08 cryptianm

add this feature please! image

cryptianm avatar Aug 14 '23 10:08 cryptianm

how actually install this plugin?

Methosss avatar Aug 17 '23 12:08 Methosss

how actually install this plugin?

It's not an official one yet, but you can install and build it yourself from the fork source.

VillainsRule avatar Aug 17 '23 13:08 VillainsRule

hey, could please add NotificationsDot component to BookmarksContainer.tsx

cryptianm avatar Aug 18 '23 21:08 cryptianm

can someone build for me dev/beta release of Vencord? with this plugin? i tried it by myself and i got bunch of errors /platform: windows

Methosss avatar Aug 20 '23 13:08 Methosss

add the ability to add channels to a folder using drag n drop

Also add the ability to see a notification dot near the folder, and near the channels within that folder.

cryptianm avatar Sep 14 '23 19:09 cryptianm

add the ability to add channels to a folder using drag n drop

Also add the ability to see a notification dot near the folder, and near the channels within that folder.

reminder that this is voluntary work people do in their free time, free of charge. do not demand that others add features, instead ask nicely or offer your suggestions in a non demanding way: "nice work! i think [feature] would be a great addition, what do you think?"

Vendicated avatar Sep 14 '23 19:09 Vendicated

add the ability to add channels to a folder using drag n drop Also add the ability to see a notification dot near the folder, and near the channels within that folder.

reminder that this is voluntary work people do in their free time, free of charge. do not demand that others add features, instead ask nicely or offer your suggestions in a non demanding way: "nice work! i think [feature] would be a great addition, what do you think?"

I'm sorry, I didn't mean to be rude in any way. Just suggested how this plugin could be improved. Thank you for making it

cryptianm avatar Sep 16 '23 17:09 cryptianm

Thank you for improving this plugin every day. I found a bug with bookmarks. When you add too many bookmarks, they don't fit on the screen. I think it would be great if you move these bookmarks to the next line? Discord's workspace will be a little smaller, but you'll be able to make a lot of bookmarks.

image

cryptianm avatar Sep 17 '23 18:09 cryptianm

Thank you for improving this plugin every day. I found a bug with bookmarks. When you add too many bookmarks, they don't fit on the screen. I think it would be great if you move these bookmarks to the next line? Discord's workspace will be a little smaller, but you'll be able to make a lot of bookmarks.

image

If you want to, you could do something similar to chrome and use the bookmark overflow. Screen Shot 2023-09-17 at 3 07 21 PM

VillainsRule avatar Sep 17 '23 19:09 VillainsRule

Thank you for improving this plugin every day. I found a bug with bookmarks. When you add too many bookmarks, they don't fit on the screen. I think it would be great if you move these bookmarks to the next line? Discord's workspace will be a little smaller, but you'll be able to make a lot of bookmarks.

image

If you want to, you could do something similar to chrome and use the bookmark overflow. Screen Shot 2023-09-17 at 3 07 21 PM

thank you for the suggestions

  • bookmark overflow probably wouldn't work because nested context menus within discord are a mess
  • moving extra bookmarks to the next like might work but could get a bit messy; might be more effort than it's worth

i'll see if i can get moving to a new line working, otherwise i'll either add a scrollbar or allow bookmarks to shrink to the point they'd always fit on screen

sunnniee avatar Sep 18 '23 11:09 sunnniee

Thank you for improving this plugin every day. I found a bug with bookmarks. When you add too many bookmarks, they don't fit on the screen. I think it would be great if you move these bookmarks to the next line? Discord's workspace will be a little smaller, but you'll be able to make a lot of bookmarks. image

If you want to, you could do something similar to chrome and use the bookmark overflow. Screen Shot 2023-09-17 at 3 07 21 PM

thank you for the suggestions

  • bookmark overflow probably wouldn't work because nested context menus within discord are a mess
  • moving extra bookmarks to the next like might work but could get a bit messy; might be more effort than it's worth

i'll see if i can get moving to a new line working, otherwise i'll either add a scrollbar or allow bookmarks to shrink to the point they'd always fit on screen

yay, discord stupidity. it's alright. thanks for making the plugin, it's looking really cool and i'm excited for release!

VillainsRule avatar Sep 18 '23 12:09 VillainsRule

Hey guys, is it possible to export my channel tabs setting to use on other device? I set up this plugin on my windows pc, and want to have the same bookmarks on my mac.

cryptianm avatar Sep 20 '23 11:09 cryptianm

image Hey guys! I think it will be cool if we'll be able to read notifications through this dropdown menu

thanks for improving this plugin :3

cryptianm avatar Oct 03 '23 18:10 cryptianm

image Hey guys! I think it will be cool if we'll be able to read notifications through this dropdown menu

thanks for improving this plugin :3

sounds like a ton of work tbh cool but not worth it

VillainsRule avatar Oct 03 '23 18:10 VillainsRule

image Hey guys! I think it will be cool if we'll be able to read notifications through this dropdown menu

thanks for improving this plugin :3

sounds like a ton of work tbh cool but not worth it

nah this'll take like 15 minutes and i'll probably do it tomorrow cause it sometimes annoys me too 👍

sunnniee avatar Oct 03 '23 18:10 sunnniee

image broken on mac :(

VillainsRule avatar Oct 04 '23 13:10 VillainsRule

very bugged on acc switcher, will not let me add or remove bookmarks, says Loading Bookmarks forever

VillainsRule avatar Oct 04 '23 20:10 VillainsRule

very bugged on acc switcher, will not let me add or remove bookmarks, says Loading Bookmarks forever

are you sure you're on the latest version of the plugin? (enabling Bookmark Notification Dot should give a Mark as Read context menu on bookmarks, if it's not there please update).

if you are, can you look for any errors (open devtools with ctrl+shift+i or cmd+opt+i for mac -> console tab) and ping me on discord (<@406028027768733696>) with a screenshot of them?

sunnniee avatar Oct 05 '23 05:10 sunnniee

best plugin ever!

cryptianm avatar Oct 05 '23 18:10 cryptianm