Vendicated
Feat: DndExclusion plugin
Added a plugin for excluding specific channels from Do Not Disturb's message notification silencing
I'm sorry to tell you this, but, someone already made a PR for this plugin: #2239
Reopening this, I feel my implementation has some major advantages to the existing PR (https://github.com/Vendicated/Vencord/pull/2239).
Yo, I’m the maintainer of the other plugin, could you lmk what advantages you were thinking of?
(Besides missing the simpler patch to do lol)
My discord username is @inbestigator
Yo, I’m the maintainer of the other plugin, could you lmk what advantages you were thinking of?
(Besides missing the simpler patch to do lol)
My discord username is @Inbestigator
This plugin has native support for custom/event sound packs, as it doesn't listen for MESSAGE_CREATE events and plays its own audio source, rather overrides Discord's own logic for determining whether a notification sound should be played. It also doesn't make a new HTTP request for each ping, which it seems yours does when looking through the code but let me know if I'm wrong about that.
As stated above, I've combined the strengths of both to create one plugin, if you'd like to improve it feel free! (dw, the devs list has both)
Adding here for posterity that I won't be closing this PR, as there's still more I'd like to do with the plugin (i.e. support for call notifications, better settings menu), but I'm fine with either being merged. If a maintainer wants to close this PR instead feel free.
Hey, just wanted to let you know that the original plugin now supports call ringtones/notifications. The settings UI has also been greatly improved.
No longer going to work on this, I feel @Inbestigator's solution has reached the point where it is better than my own and I am now too enamoured by other projects to put more work into this. :)