Port volume booster to web/vesktop
resolves: #1944 ports volume booster to web/vesktop
TODO:
- [x] don't error on screenshare
- [x] adjust volume?
- [x] fix deafening
It does raise the volume but it doesnt seem to be ex: 500% louder.
also it basically functions as a fake deafen at the moment.,...
It does raise the volume but it doesnt seem to be ex: 500% louder.
yeah this was my experience too
also it basically functions as a fake deafen at the moment.,...
we cannot ship that, theres a good reason why fake deafen is explicitly not a feature, regardless of that I think I'd still like to have a "I want my friends to be quiet for a bit" button
also it basically functions as a fake deafen at the moment.,...
somehow I didn't notice this, thanks!
You are doing two webpack searches yet only one is used, remove the other one
also the code style doesn't match the rest of project, mainly the spacing in if conditions
You are doing two webpack searches yet only one is used, remove the other one
also the code style doesn't match the rest of project, mainly the spacing in if conditions
I may be a tad stupid, but what are/were you referring to by the spacing in if conditions
i think it would be a good idea to extract this into a separate plugin like WebExtraVolume and make it enabled by default. That way more users can profit from it and Vesktop users will get the expected stock equivalent behaviour
i think it would be a good idea to extract this into a separate plugin like WebExtraVolume and make it enabled by default. That way more users can profit from it and Vesktop users will get the expected stock equivalent behaviour
It depends on the patches already introduced by Volume Booster.
Is there anything I can help with to get this merged? :) Would love to have this feature on web/vesktop
This should be ready as i fixed the stock discord issue that made it glitch out at low volumes
Thank you!
Apparently this isn't working on the vesktop, which is weird because that's where I tested it. I have family over today, but I will work on it tomorrow if nobody else fixes it