Vencord icon indicating copy to clipboard operation
Vencord copied to clipboard

Port volume booster to web/vesktop

Open sadan4 opened this issue 1 year ago • 7 comments

resolves: #1944 ports volume booster to web/vesktop

TODO:

  • [x] don't error on screenshare
  • [x] adjust volume?
  • [x] fix deafening

sadan4 avatar Jul 27 '24 03:07 sadan4

It does raise the volume but it doesnt seem to be ex: 500% louder.

also it basically functions as a fake deafen at the moment.,...

Covkie avatar Jul 28 '24 21:07 Covkie

It does raise the volume but it doesnt seem to be ex: 500% louder.

yeah this was my experience too

also it basically functions as a fake deafen at the moment.,...

we cannot ship that, theres a good reason why fake deafen is explicitly not a feature, regardless of that I think I'd still like to have a "I want my friends to be quiet for a bit" button

Sqaaakoi avatar Jul 28 '24 21:07 Sqaaakoi

also it basically functions as a fake deafen at the moment.,...

somehow I didn't notice this, thanks!

sadan4 avatar Jul 29 '24 00:07 sadan4

You are doing two webpack searches yet only one is used, remove the other one

also the code style doesn't match the rest of project, mainly the spacing in if conditions

Nuckyz avatar Aug 02 '24 14:08 Nuckyz

You are doing two webpack searches yet only one is used, remove the other one

also the code style doesn't match the rest of project, mainly the spacing in if conditions

I may be a tad stupid, but what are/were you referring to by the spacing in if conditions

sadan4 avatar Aug 02 '24 16:08 sadan4

i think it would be a good idea to extract this into a separate plugin like WebExtraVolume and make it enabled by default. That way more users can profit from it and Vesktop users will get the expected stock equivalent behaviour

Vendicated avatar Aug 15 '24 13:08 Vendicated

i think it would be a good idea to extract this into a separate plugin like WebExtraVolume and make it enabled by default. That way more users can profit from it and Vesktop users will get the expected stock equivalent behaviour

It depends on the patches already introduced by Volume Booster.

sadan4 avatar Aug 15 '24 14:08 sadan4

Is there anything I can help with to get this merged? :) Would love to have this feature on web/vesktop

MaxBosse avatar Aug 30 '24 16:08 MaxBosse

This should be ready as i fixed the stock discord issue that made it glitch out at low volumes

sadan4 avatar Aug 30 '24 23:08 sadan4

Thank you!

Nuckyz avatar Sep 01 '24 03:09 Nuckyz

Apparently this isn't working on the vesktop, which is weird because that's where I tested it. I have family over today, but I will work on it tomorrow if nobody else fixes it

sadan4 avatar Sep 01 '24 15:09 sadan4