Vencord icon indicating copy to clipboard operation
Vencord copied to clipboard

Migration to flat config

Open SomeAspy opened this issue 1 year ago • 3 comments

This PR migrates the ESLint config away from .eslintrc.json to eslint.config.mjs

  • Updated ESLint related packages (including the patch for no-useless-escape)

I tried to keep changes minimal, but some things probably should be checked.

  • Unsure if path-alias/no-relative rule is working. I think the plugin needs to be updated. (Upstream is as ~v2) However, this was another patched package, and I do not have an adequate understanding of patches to re-patch it (Upstream has been rewritten to TS, but its a simple patch so I don't think it should be too hard)
  • Some weird indentation issues in src/utils/types.ts, src/shared/SettingsStore.ts, and src/api/Settings.ts I am leaving these up to you to review, as I'm not sure what your preference is.
  • A few other warnings (6 unused eslint-disables. Leaving this up to you to review.)

SomeAspy avatar Jun 25 '24 20:06 SomeAspy

Hi @Vendicated I was able to patch the package in c9982b5, and this resolved the issues related to no-relative It's not very clean, but the node module is all minified so I don't think it can be any better than it is at the moment.

SomeAspy avatar Jun 26 '24 00:06 SomeAspy

oh god wtf is that diff

Vendicated avatar Jun 26 '24 00:06 Vendicated

thanks I'll have a look tomorrow

Vendicated avatar Jun 26 '24 00:06 Vendicated

thanks for your work!

Vendicated avatar Aug 02 '24 10:08 Vendicated

Thanks a lot!!

Nuckyz avatar Aug 02 '24 13:08 Nuckyz