Vendicated
[Plugin] Drag favorite emotes
Okay so right now it's very very very WIP, (although 90% of functionality is there)
But in the update function, it basically is hard coded to make 1 real drag (by setting a global flag).
Right now that's with the purpose of debugging, because if you modify the emoji order, for some reason the drag data doesn't update, so when you try to do a second drag it references the old data.
(You can test this by putting a log-point/console.log/breakpoint in the drop function, and seeing that source and target are the ones that were there before the change)
(It was memoization, fuck react)
Please also make sure to run eslint in your project so your formatting matches the rest of the repo
All the functionality works now, purged all the bugs (maybe I actually need to return something to FrecencyUserSettingsActionCreators but unsure).
The thing is I am not familiar how to create patches and I know I have a few hardcoded variables,
like the Y to get target emote, I'll try to fix it as best I can.
Editable PR
Also I can't make the PR editable, because I have an organization for my forkshttps://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
Okay, I have made the best effort to get a better find and to replace all hard coded variables.
In my eyes, all is done, the only improvements you could make is make the drag item, be only the emote, but for native emojis, it's a pain. Although it is fairly easy for custom emotes with getEmojiURL.
force pushing kinda horror it'll get squashed into 1 commit later
Half the force pushes, are rebases.
Heads up; over the past week I've noticed that this plugin causes Discord to crash whenever you type text into the "add reaction" emoji picker; the React error message is "Rendered fewer hooks than expected. This may be caused by an accidental early return statement."
hi, are you still interested in continuing this pr? if not, do you mind if I finish it? I really like the idea and want to see it merged.
hi, are you still interested in continuing this pr? if not, do you mind if I finish it? I really like the idea and want to see it merged.
Is there something to finish? Did it break? When I left it was pretty much done as far as I remember.