Vencord icon indicating copy to clipboard operation
Vencord copied to clipboard

MediaPlaybackSpeed plugin

Open D3SOX opened this issue 1 year ago • 6 comments

New icon with menu to change the playback speed

D3SOX avatar Jun 01 '24 14:06 D3SOX

pretty cool! please make sure this is compatible with the voice message download plugin

Vendicated avatar Jun 01 '24 15:06 Vendicated

😳

realPrix avatar Jun 01 '24 16:06 realPrix

actually what do you think about merging this plugin with the aforementioned voice message download plugin?

like BetterVoiceMessages or smth

Vendicated avatar Jun 03 '24 18:06 Vendicated

@Vendicated Hm I can imagine doing it but I don't think that name fits. Because this also applies to video embeds

D3SOX avatar Jun 03 '24 21:06 D3SOX

Addressed the requested changes. It's already compatible with the VoiceDownload plugin if you meant this with VCMDownload

D3SOX avatar Jun 06 '24 09:06 D3SOX

Any updates? This is such a simple plugin and I resolved every review remarks a few minutes after they were sent..

D3SOX avatar Jul 01 '24 11:07 D3SOX

Is this actually happening? After over a year? I don't even know if the code in this PR is still up-to-date lol. Let me take a look at your review and I will get back soon :) I think Discord has speed controls for Voice Messages (but not for other media elements.) nowadays. I definitely need to update the patch to remove them because the plugin provides more options.

D3SOX avatar Sep 04 '25 07:09 D3SOX

Oops, just noticed I broke that it controls the speed for voice messages, working on a fix

D3SOX avatar Sep 04 '25 08:09 D3SOX

Done. I had to grab the ref from above, let me know if the patch is okay

D3SOX avatar Sep 04 '25 09:09 D3SOX

doesn't seem aligned and it'd be way better to make it a hover thing like the volume slider

image

Vendicated avatar Sep 04 '25 15:09 Vendicated

I like that idea. Might work on this in the next days.

My leftover stuff that would be nice to have:

  • Showing the current speed on the button
  • Making it work in fullscreen
  • Make speed range configurable

D3SOX avatar Sep 04 '25 15:09 D3SOX

yep those sound important too

also would be nice to make it remember the previous speed (in the current session? or even previous sessions? idk), toggleable in settings

Vendicated avatar Sep 04 '25 16:09 Vendicated