Vencord icon indicating copy to clipboard operation
Vencord copied to clipboard

Added CustomPFP plugin

Open luca99y opened this issue 10 months ago • 12 comments

Adds 2 commands /add pfp [user id] [Profile picture] It takes a user id and a link to a profile picture to change the PFP of any user. /remove pfp [user id] It takes a user id and removes the custom pfp added

luca99y avatar Apr 20 '24 17:04 luca99y

i don't really see use for this but it might be useful for some 🙍‍♂️

Tr0llie avatar Apr 20 '24 22:04 Tr0llie

i don't really see use for this but it might be useful for some 🙍‍♂️

is probably a rare use but now that i think of it, it would allow people to not download images. which is a good thing in itself

Tr0llie avatar Apr 20 '24 22:04 Tr0llie

You toke the userpfp plugin and just changed it a bit?

thororen1234 avatar Apr 21 '24 02:04 thororen1234

Which user pfp plugin?

luca99y avatar Apr 21 '24 04:04 luca99y

Which user pfp plugin?

https://github.com/Vendicated/Vencord/pull/1956

thororen1234 avatar Apr 24 '24 02:04 thororen1234

Which user pfp plugin?

#1956

Oh i didnt know about it

luca99y avatar Apr 24 '24 10:04 luca99y

The commands sound like an admin feature for the people that made and run UserPFP (Me included). Unless of course you want every user being able to change everyone else's profile picture. We don't need this functionality, though a client side requesting feature would be good, if you want you can ask Nexxpid if you can take the code and add a requesting feature. Contact me on Discord for more.

coolesding avatar Apr 25 '24 04:04 coolesding

The commands sound like an admin feature for the people that made and run UserPFP (Me included). Unless of course you want every user being able to change everyone else's profile picture. We don't need this functionality, though a client side requesting feature would be good, if you want you can ask Nexxpid if you can take the code and add a requesting feature. Contact me on Discord for more.

My use for it was if someone has something as a pfp that is offensive to you that you can change it to something less offensive like your ukrainian and one of your friends has russian flag you could just change it

luca99y avatar Apr 25 '24 09:04 luca99y

Which user pfp plugin?

#1956

Oh i didnt know about it

So if you didn't know, for a few questions why is the let data needed if it isn't used besides what's above the name of the plugin which can be removed, the patch is clearly just a copy and paste with the note included, even the avatarhook was barely changed. So after all of that are you positive you didn't know it existed?

Im very sure that i did not copy paste it the only plugin i took inspiration from was pindms for saving data

luca99y avatar Apr 25 '24 09:04 luca99y

The commands sound like an admin feature for the people that made and run UserPFP (Me included). Unless of course you want every user being able to change everyone else's profile picture. We don't need this functionality, though a client side requesting feature would be good, if you want you can ask Nexxpid if you can take the code and add a requesting feature. Contact me on Discord for more.

what? this pr has nothing to do with your project. it's just a plugin to locally change user's pfps akin to the betterdiscord EditUsers plugin

Vendicated avatar Apr 25 '24 11:04 Vendicated

hi, thanks for your pr!

i think this feature itself is a good idea but the implementation is bad

why only support the pfp? it would be way nicer if this allowed you to change all user properties just like the existing EditUsers plugin for BD. like username, nickname, pfp, banner and name colour in chat

and instead of using slash commands it would be way nicer to have a button in the user context menu that opens a modal where you can customise everything

Vendicated avatar Apr 25 '24 11:04 Vendicated

closing because this is still way too specific / niche, but like i said a proper generic EditUser plugin would be more than welcome

thanks for your efforts

Vendicated avatar Jun 06 '24 02:06 Vendicated

My use for it was if someone has something as a pfp that is offensive to you that you can change it to something less offensive like your ukrainian and one of your friends has russian flag you could just change it

Is this a joke?

CodeByAidan avatar Aug 31 '24 22:08 CodeByAidan