Vencord icon indicating copy to clipboard operation
Vencord copied to clipboard

feat(plugin): ValidReply

Open waresnew opened this issue 1 year ago • 5 comments

Basically same thing as ValidUser but for replies

Should I just merge this into ValidUser instead of making a new plugin actually? Might have to rebrand the name then

Discord_nwGtV4zYbv

waresnew avatar Apr 06 '24 21:04 waresnew

this is awesome

cheesesamwich avatar Apr 06 '24 22:04 cheesesamwich

very nice will be an epic merge

Golonchy avatar Apr 08 '24 03:04 Golonchy

since this is gonna be a very rare occurence, i don't think having the hover requirement is necessary

Vendicated avatar Apr 08 '24 15:04 Vendicated

since this is gonna be a very rare occurence, i don't think having the hover requirement is necessary

In one of the servers I'm in, ctrl+F'ing for a certain term guarantees all the replies in the search results to be unloaded (maybe bc the results are spaced apart in terms of timestamp)

So I'm worried if not having a hover check would send like 10 requests at once if the user starts scrolling through the search results (or I could just use a queue)

waresnew avatar Apr 08 '24 15:04 waresnew

if it can't fetch the message, it'll update the reply to say it was deleted now (i tried manually looking for a reply that couldn't be loaded by the plugin and it turns out it was indeed deleted)

this is mainly a UX thing

Discord_I268lLW8t8

waresnew avatar Apr 15 '24 19:04 waresnew

thanks, looks good!

your formatting doesn't follow the project's configured formatter. make sure you're using vscode & have the suggested extensions installed! also in general i recommend using more newlines to separate different sections/"paragraphs" of the code

Vendicated avatar May 15 '24 02:05 Vendicated

thanks, looks good!

your formatting doesn't follow the project's configured formatter. make sure you're using vscode & have the suggested extensions installed! also in general i recommend using more newlines to separate different sections/"paragraphs" of the code

thank you! I'm kinda busy rn but I'll update the formatting of my other prs when I have time.

in terms of the formatting, I use jetbrains and it has eslint + editorconfig installed, so idk why it didn't autoformat

waresnew avatar May 15 '24 02:05 waresnew

ah, that's because Vencord is configured to use the vscode formatter via .vscode workspace config file image

it isn't really configured to work with other editors. i suggest just formatting your code once with vscode before pushing to github. sorry for the inconvenience...

Vendicated avatar May 15 '24 02:05 Vendicated