Vencord icon indicating copy to clipboard operation
Vencord copied to clipboard

fix(ShowMeYourName): Update names in typing indicator

Open refact0r opened this issue 1 year ago • 5 comments

first contribution, hopefully i didnt fuck anything up

image

refact0r avatar Apr 03 '24 23:04 refact0r

Polluting the user object with a nick property is bad

Nuckyz avatar Apr 03 '24 23:04 Nuckyz

copied the GuildMemberStore/RelationshipStore method to get nicks from the TypingTweaks plugin.

refact0r avatar Apr 04 '24 00:04 refact0r

is this compatible with TypingTweaks?

Vendicated avatar Apr 09 '24 00:04 Vendicated

ok i just checked and it is not. how should i make it compatible?

i assume i should just add a predicate that disables the patch if typingtweaks is enabled.

ideally if both are enabled at once the typingtweaks names would display in the showmeyourname format. is cross-plugin behavior like that even allowed?

refact0r avatar Apr 09 '24 02:04 refact0r

is cross-plugin behavior like that even allowed?

Plugins should be naturally compatible with each other (that's why patches are written in a specific way, to preserve functionality), and ideally we shouldn't be adding checks to see if other plugins are enabled. If it's absolutely necessary, then so be it, but please prefer finding a solution where both can work at once without special handling.

lewisakura avatar Apr 16 '24 09:04 lewisakura