Vencord
Vencord copied to clipboard
Vendicated
[Plugin] HideMessage
How is this different from the existing delete message button?
The Delete Message button deletes the message you sent from everyone. The difference of this plugin is that it only deletes the message from your client, it does not send any API requests.
How is this different from the existing delete message button?
The Delete Message button deletes the message you sent from everyone. The difference of this plugin is that it only deletes the message from your client, it does not send any API requests.
what's the use case for this even
I guess maybe if you're taking screenshots and you want to delete stuff that contains private info or irrelavent stuff?
How is this different from the existing delete message button?
The Delete Message button deletes the message you sent from everyone. The difference of this plugin is that it only deletes the message from your client, it does not send any API requests.
what's the use case for this even
Sometimes our friends and other people can send nsfw or disturbing images/content in a text channel that we don't want to see in a public place. This plugin removes the message from the DOM on demand. Kind of WhatsApp does but without a storage mechanism. When you reload your client the messages will be shown again.
I guess maybe if you're taking screenshots and you want to delete stuff that contains private info or irrelavent stuff?
Exactly.
I think this could do with a rebranding. Imo, "Delete From Me" doesn't make much sense. I would change it to "Hide Message".
You are absolutely right. I changed the plugin name to Hide Message.
Haven't tried this plugin but I feel, if it's not already implemented, that there should be a button to show all hidden messages without having to reload your client. Maybe this could be a command or something that show when you right click a message.
Haven't tried this plugin but I feel, if it's not already implemented, that there should be a button to show all hidden messages without having to reload your client. Maybe this could be a command or something that show when you right click a message.
Implemented in my latest commit
It's been 2 weeks and no one is looking at PR. Why is that? @Vendicated
vee reviews PRs when they are motivated to, be patient
There is over a hundred PRs with some dating over a year ago, someone will eventually review your PR but until then it's best to just forget about this until you get that magic notification, my PR for the same function took place over 9 months ago
There is over a hundred PRs with some dating over a year ago, someone will eventually review your PR but until then it's best to just forget about this until you get that magic notification, my PR for the same function took place over 9 months ago
They're literally making fun of people 😂
Your PR will not be reviewed if you keep asking about it. Please be patient, we have other things to do both for the project and in life.
Your PR will not be reviewed if you keep asking about it. Please be patient, we have other things to do both for the project and in life.
A month has passed and the pull request has still not been merged. You say we have things to do in our lives, but a pull request opened 4 hours ago is merged. There are people who have been waiting for a year. If you are not going to approve it, close this pull request and don't drag it out any longer.
Okay, I don't normally do codereview for plugins anymore, but I'll give a response.
As it stands this plugin is not suited to be merged - creating tons of CSS for hiding messages is not effective and will eventually create a client slowdown. You don't need to manipulate the DOM to do this, you need to create a patch that filters out the hidden messages by ID when the channel view is rendered. I flagged this up previously but it seems like it was dismissed.
I'd also like to point out there is no reason to use that quote against me when I am not the one merging pull requests, because at the time the statement was true and everyone was busy with work, IRL, etc. including myself. I still am and so are many other people. One person starting to merge PRs that are at the top of the list is nothing new but many PRs from time immemorial are getting picked up too and slowly being worked on. I'm sorry that yours got buried, but if it is that much of an issue, then please just close the PR so we can mutually not worry about it. We are also concerned with the number of open PRs and haven't had time to just sit down and go through all of them.
yeah, as pointed out by lewi, this current implementation is not very good. using css for this is hacky and not sustainable. this was already pointed out two months ago but never addressed. HideAttachments suffers from very much the same problem and honestly needs a rewrite, it's just that it's very old (made within the first two months of vencord existing), that's why it doesn't follow the quality standard as much as other plugins
in the current state this is not mergeable for that reason. here are a few better approaches i can think of:
- patch the message component to render null for hidden messages
- patch somewhere else to filter out undesired messages
- dispatch MESSAGE_DELETE events for the hidden messages
prs are looked at and merged whenever they are looked at and merged. this is a hobby project and there is a long backlog of contributions. this is not a very high priority change. if you are not okay with waiting, you probably shouldn't be contributing
