Vencord
Vencord copied to clipboard
Vendicated
feat(MoreUserTags): Role Colors for User Tag
This feature is inspired by https://github.com/Puyodead1/replugged-stafftags It took me 3 hours to figure out how to do this in Vencord and I'm so glad I did because it looks just so much better Basically it allows setting a toggle in settings that makes staff tags have the same background as the member's role, falling back to the default colors it was before.
A screenshot of the concept. The first image was a screenshot of replugged-stafftags and the second was a screenshot of the then-vencord plugin. This is a screenshot of a screenshot, so you can see my modification in action near the top.
Here are some more screenshots, demonstrating that it can support both dark and light role colors. It also works in the member list and on profiles.
This is my first contribution to Vencord, so let me know if I should make any changes!
Note: The patches may seem over-engineered, but as the member object is not accessible within the section where it creates the bot tag, the colors need to be passed from the place it exists to where it needs to go. The extra patches are designed to do that.
I'm working on ammending this PR to only edit the colors of tags if they also contain staff information - We still want to see the normal discord branding for tags that don't have staff perms but do have role colors, especially in the member list
You need a maintainer to approve this workflow to run since this is your first contribution
You need a maintainer to approve this workflow to run since this is your first contribution
I see. Thank you. I will continue to wait patiently.
Is there something I have to do to let this PR be reviewed? Like, is there some sort of convention that this repo follows that I missed?
I should have done this PR in a side branch instead of the main branch of my fork so that I could work on other prs without them depending on this one
Banished to the second page of PRs, rip. I feel like i can't use vencord without this change so hopefully i'll figure out how to build the browser extension myself.
Has this rolled out for everyone? Maybe it should check the experiment if possible (I haven't seen any other plugin do this 🤷🏻♀️)
Has this rolled out for everyone? Maybe it should check the experiment if possible (I haven't seen any other plugin do this 🤷🏻♀️)
I don't know if it has an experiment and I'm not sure how to check. Could you please let me know if you find one?
Has this rolled out for everyone? Maybe it should check the experiment if possible (I haven't seen any other plugin do this 🤷🏻♀️)
afaik it doesn't have an experiment. The change is also on stable now.
It has an experiment. "App Launcher - Onboarding"
Does that actually affect the app vs bot text? If so, how do I get it within vencord?
It has an experiment. "App Launcher - Onboarding"
Does that actually affect the app vs bot text? If so, how do I get it within vencord?
experiments plugin!?!?!?
It has an experiment. "App Launcher - Onboarding"
Does that actually affect the app vs bot text? If so, how do I get it within vencord?
experiments plugin!?!?!?
I mean how do I programatically find the status of the experiment from within a plugin
I mean how do I programatically find the status of the experiment from within a plugin
Most of them are their own modules. Luckily this one has named exports because it exports two experiments, so you can just findByProps("AppLauncherOnboardingExperiment").
Also thanks to whoever allowed checks to run on this single commit out of this pr's entire history. Unexpected but it felt good to know that my PR does, in fact, work on your machine as well as mine.
@Cynosphere Discord just removed the experiment, and also changed their original code so that the app tag is used 100% of the time
Adding backwards compatibility to maintain consistency with dev: https://github.com/Vendicated/Vencord/commit/c10466f607d889c06afdee46f7af31b1062e78b5