feat(plugin): FakeProfileThemesAndEffects

[ryan-0324]

This plugin is meant to replace FakeProfileThemes. It allows profile theming and the usage of profile effects by hiding the colors and effect ID in your About Me using invisible, zero-width characters.

• It includes a UI (called the FPTE Builder) for generating the profile theme/effect (FPTE) strings in the User Profile and Server Profiles settings pages.
• The FPTE strings can be made backwards compatible so that users of older plugins will still see your profile theme.
• When the "Build backwards compatible FPTE" setting is off, the generated strings will use at most 22 characters (12 codepoints) of your About Me.
• The FPTE Builder can be hidden through the plugin settings.

[Vendicated]

this is a crazy amount of code for such a small feature. why is all of this needed? it seems very overengineered

[ImpishMoxxie]

LGTM 👍

[tiagorangel1]

Looks good

[beatmakerofficial]

How do I use it? @ryan-0324

[ryan-0324]

@rniii Do you know what could be causing the Invalid header errors? All of my headers were automatically added on save.

[omegion3]

get that thing declined, because this is reupload from discord assets.

now if only we get custom profile effects, rather then just a reupload one, this would've be prefect.

[MrDiamondDog]

get that thing declined, because this is reupload from discord assets.

now if only we get custom profile effects, rather then just a reupload one, this would've be prefect.

What are you talking about

[omegion3]

What are you talking about

nah i'm just kidding, even though it's a reupload assets, but i hope this plugin will merge

[MrDiamondDog]

nah i'm just kidding, even though it's a reupload assets, but i hope this plugin will merge

It doesn't have reuploaded assets..?

[omegion3]

It doesn't have reuploaded assets..? well it does sadly, but hopefully someone might plan to make custom profile effect or this plugin will finally merge.

[CompeyDev]

What's the status on this? Anything blocking a merge on this?

[Sqaaakoi]

What's the status on this? Anything blocking a merge on this?

vee gets around to PRs "eventually" this is also (relatively) a big plugin

[CompeyDev]

Makes sense, I'm running a manually compiled build from ryan's repo and it seems to work about fine. Haven't really looked much at the code though.

[Covkie]

Some issues:

1. The stock profile effect editor is patched by this plugin resulting in it displaying all effects as unlocked and are unable to apply any & it falsely showing the remove effect button. Should behave like Decor where it doesn't modify the stock feature.

2. The FPTE Builder should auto fill with the values from the bio.

3. The FPTE Builder should have buttons to save to bio without manual copy & pasting being required And likewise have a clear button.

[ryan-0324]

Some issues:

1. The stock profile effect editor is patched by this plugin resulting in it displaying all effects as unlocked and are unable to apply any & it falsely showing the remove effect button. Should behave like Decor where it doesn't modify the stock feature.
2. The FPTE Builder should auto fill with the values from the bio.
3. The FPTE Builder should have buttons to save to bio without manual copy & pasting being required And likewise have a clear button.

1. This seems to be a recent breakage. Thanks for letting me know.
2. I've though about adding something like this before, and it seems reasonable.
3. This has been suggested before, and I don't think it's worth the added complexity:
   1. Should I just prepend the FPTE string to the user's bio, displaying an error if their bio doesn't have enough space or already starts with an FPTE character?
   2. Or should I try to automatically detect preexisting FPTE strings and strings from other plugins, and remove them from the user's bio, showing an error if there still isn't enough space?
   3. If not (ii), when the user's bio already starts with an FPTE character, should I add a non-FPTE character as a separator, or should I display an error?
   4. Should I send an API request to save the user's bio, or should I have the user do it manually?

[Covkie]

The stock profile effect setting still falsely shows the "Remove Effect" button

Or should I try to automatically detect preexisting FPTE strings and strings from other plugins, and remove them from the user's bio, showing an error if there still isn't enough space?

Bio processing is already in place, can you not just replace the detected/processed fpte string

Should I send an API request to save the user's bio, or should I have the user do it manually?

The user should do it manually imo