Vitalii Kryvenko

Results 283 comments of Vitalii Kryvenko

> given from_iter implies `impl Iterator` when it's really `impl IntoIterator` I agree. It's unfortunate this naming choice was established in Rust [`FromIterator` trait](https://doc.rust-lang.org/stable/std/iter/trait.FromIterator.html) that actually powers the `.collect()` method....

Glad to hear that! I noticed that you added `bon` as a git dependency to your project. Is there any reason not to use it from [`crates.io`](https://crates.io/crates/bon)?

I added an annotation `#[builder(with = ...)]` that accepts a custom closure or a well-known function #157 / #145. For the case of accepting an `IntoIterator` parameter specifically, it's possible...

`3.0.0-rc` version was published. I'll prepare a blog post for the release and switch it to `3.0.0` on November 13-th

> Would it be possible to change the name of the builder and keep the original function unchanged? E.g. for this to work: The main idea is that the function's...

On the other hand.. It's understandable that you'd expect `expose_positional_fn` to flip this behavior where the positional function name is preserved and you need to specify a function for the...

I updated [the docs](https://elastio.github.io/bon/docs/guide/compatibility#adding-builder-to-existing-code) with the example above. I'll keep this issue open as a feature request to implement the syntax in your proposal where the positional function's name stays...

I don't think a major version will be required for this feature. The default behavior should still be such that the function's name is used for the builder function. However...

```rust #[builder(start_fn = example_builder, expose_positional_fn = example)] ``` Such syntax should be a compile error, because now there are 3 names involved, when only 2 are needed. > Does the...

Hey @drmason13 I've just found a probably unrelated bug, but I want to make sure the fix won't affect your code. The bug is that when you place `#[builder]` on...