sigkit icon indicating copy to clipboard operation
sigkit copied to clipboard

New duplicate symbol handling breaks sig-gen during alias enumeration

Open amtal opened this issue 4 years ago • 1 comments

Exception thrown due to using removed API: https://github.com/Vector35/sigkit/blob/master/compute_sig.py#L242

API commit removing Symbol.aliases property: https://github.com/Vector35/binaryninja-api/commit/ccc46ee23e8160231b1de739380bd7d808ec433d#diff-be75236b09e0ec25f6e7192bfcb0d69ef8467d6efa8bed2161108cf4e57559bc

Temp. workaround of info.aliases = [] #, proper fix ???

amtal avatar May 03 '21 02:05 amtal

Looks like sigkit should probably be fixed. Replace func.symbol.aliases with:

func.view.get_symbols(func.symbol.address, 1)

Except it looks like info.aliases is expecting a list of strings and the code above will yield symbol objects. Just need to extract the name from each object as well.

bpotchik avatar May 03 '21 02:05 bpotchik