debugger icon indicating copy to clipboard operation
debugger copied to clipboard

Create new icons for TTD sidebars

Open xusheng6 opened this issue 3 months ago • 5 comments

We need a few new icons for the TTD sidebars that I am working on. These include:

  1. TTD Memroy queries
  2. TTD Calls queries
  3. General TTD analysis
  4. Time-travel to a specific timestamp

More details can be provided if necessary

xusheng6 avatar Sep 09 '25 14:09 xusheng6

Sorry @xusheng6, I lost track of this. It wasn't on the milestone, so I wasn't thinking about it. Found it when I was going back through a whole bunch of things I'd left open in a browser window.

I don't really understand the TTD interface. Visually, it's very different from what we do in the rest of the product. For example, the close buttons are the default big red X thing and the tabs look like a 4th type of tab we don't have elsewhere in the product?:

Image

I also don't understand where you need these icons to go. I see that there's some placeholder TTD icon that I can't make sense of, so I think you obviously need a "TTD Calls sidebar icon" is this number 3 in your list above?

I also see two different buttons for "Query TTD Calls" and "Clear Results". Are those things I'm supposed to be creating icons for? Or..? Just confused about what some of the things you're asking for are here, and if there's anything you already had in mind for what to put on the icons.

fuzyll avatar Oct 18 '25 00:10 fuzyll

Basically I need these ones:

  1. icon for TTD memory sidebar: https://github.com/Vector35/debugger/blob/dev/icons/ttd-memory.png
  2. icon for TTD calls sidebar: https://github.com/Vector35/debugger/blob/dev/icons/ttd-calls.png
  3. icon for jump to timestamp in the controls button area: https://github.com/Vector35/debugger/blob/dev/icons/ttd-timestamp.png

These ones are done by AI and already shipped on dev. I just hope we can have better ones that visually match our other icons

As a headsup, I will also need these ones

  1. icon for TTD events sidebar
  2. icon for TTD heap sidebar
  3. icon for a TTD analysis sidebar

The "Query 1" thing you showed in the screenshot is not what I am thining

xusheng6 avatar Oct 18 '25 01:10 xusheng6

Now that you noticed the tab UI mismatch with other parts -- yes, the tab is just using the normal Qt tab, which is different from how we do tabs for the main binja window. I believe it would be great if we can unify them, but I was trying to ship faster and kinda skipped it for the time being. I can get back to it later

xusheng6 avatar Oct 18 '25 01:10 xusheng6

All good, I just didn't want us to forget. I think I'm understanding now? Where is the "jump to timestamp" thing used right now? Or is it in an upcoming thing?

One of the problems I'm having with the sidebar icons is how to differentiate them from the "history" sidebar icon, which already uses a watchface. But, that's a "me" problem. 🙂

fuzyll avatar Oct 18 '25 01:10 fuzyll

All good, I just didn't want us to forget. I think I'm understanding now? Where is the "jump to timestamp" thing used right now? Or is it in an upcoming thing?

One of the problems I'm having with the sidebar icons is how to differentiate them from the "history" sidebar icon, which already uses a watchface. But, that's a "me" problem. 🙂

The jump to timestamp button is used in the controls button area in the main debugger sidebar. It comes after things like step over, reverse step over, etc

xusheng6 avatar Oct 18 '25 02:10 xusheng6