obey ui.theme.colorBlind

Open psifertex opened this issue 3 years ago • 3 comments

Instead of always green/red, the icon colors should obey ui.theme.colorBlind

Oct 18 '22 14:10 psifertex

I /think/ I used the recommended way to retrieve those colors, which should be aware of color bind settings and return the color with that taken into account, but I need to check it

Nov 01 '22 09:11 xusheng6

The ui.theme.colorBlind settings only affects TrueBranchColor, FalseBranchColor, and UnconditionalBranchColor. It does not affect colors like RedStandardHighlightColor or RegisterColor. That is the reason why we are still seeing red colors in several places of the debugger UI.

Feb 03 '23 05:02 xusheng6

Related to https://github.com/Vector35/binaryninja-api/issues/3860

Feb 03 '23 08:02 xusheng6