binaryninja-api icon indicating copy to clipboard operation
binaryninja-api copied to clipboard

Changes to referenced types not causing HLIL regeneration

Open op2786 opened this issue 6 months ago • 2 comments

Version and Platform (required):

  • Binary Ninja Version: 5.1.7557
  • OS: Macos
  • OS Version: 15.5
  • CPU Architecture: arm64

Bug Description: Structure member name changes does not reflected to the linear view for globally defined structures.

Image

When I rename field_0 to test_1 this is what happens:

Image

op2786 avatar Jun 04 '25 08:06 op2786

Hi @op2786 , can you provide the database for us to repro it easier?

Also, I believe the underlying issue is that we did not calculate the function xref of the field correctly. Does it update properly if you re-analyze the function?

xusheng6 avatar Jun 09 '25 07:06 xusheng6

If not could you provide just the bytes of the disassembly?

plafosse avatar Jun 16 '25 19:06 plafosse

I've sent the binary to @xusheng6 in slack. Sorry for late response.

It does update properly when I re-analze the function.

op2786 avatar Jun 19 '25 14:06 op2786