Vector35
"Select None" Not Working
Version and Platform (required):
- Binary Ninja Version: 4.1.5902
- OS: macOS
- OS Version: 14.6.1 (23G93)
- CPU Architecture: x64
Bug Description: The "Select None" entry in the "Edit" menu does not clear the selected instruction when in Linear View. Also, if you have a particular token selected in the Graph View and then use "Select None" the selection of a particular instruction is cleared, but the selection of a particular token remains. Look at the screenshots below to see that the behavior in Linear and the behavior in Graph are both working incorrectly in opposite ways.
Steps To Reproduce:
- Set Linear View
- Select any instruction line
- In the Edit menu click "Select None"
- Notice instruction still selected
- Change to Graph View
- Select one token (eax for example)
- In the Edit menu click "Select None"
- Notice cleared instruction but remaining token is selected.
Expected Behavior: All selected entities in the view will be unselected
Screenshots/Video Recording:
Before:
After Select None:
Before:
After Select None:
Btw, I am just curious -- what actually prompts you to use the ""Select None" action? Normally I would think one can do it by just clicking at a location where there is nothing to achieve the same goal
Clean screenshots of your beautiful UI. Both of those views, when using Select None, leave at least one UI element still selected. And, yes, clicking somewhere else is one workaround, but isn't a workaround for small functions where there isn't anywhere off-screen that one can click.
A better workaround might be to use Select None from the command palette (Cmd-P), which appears to work correctly in linear view.
@fuzyll Command pallete does the same thing. At least on macos. are you testing on macos?
https://github.com/user-attachments/assets/12f474b4-b141-4395-8db7-1e9a7571a8b3
Oh, I understand now. No, you are correct, it also doesn't work. It removes all of the selections except for the current line in linear view. I misread what you were saying earlier.
Yes, and interestingly, Graph and Linear have opposite behaviors. Select None leaves the instruction selected or leaves the token selected depending on which view you're looking at.
Forgot to update this, but I believe Graph View should be fixed as of builds >= 4.2.6025-dev. Linear View was not quite as easy and I haven't finished fixing that yet.
Should be fixed in builds >= 4.2.6105-dev. I had made two changes to linear view earlier, which cancelled each other out. Making just one of them was more successful. 🙂