binaryninja-api icon indicating copy to clipboard operation
binaryninja-api copied to clipboard

Undefining a string data variable does not update the analysis of the function that references it

Open xusheng6 opened this issue 1 year ago • 2 comments

Repro steps:

  1. Open the helloworld binary from https://github.com/Vector35/debugger/blob/dev/test/binaries/Darwin-arm64/helloworld
  2. Navigate to 0x100003f90, undefine the data variable
  3. The main function is NOT re-analyzed

xusheng6 avatar Aug 02 '24 09:08 xusheng6

This only sees to hurt string data variable, I briefly looked into it and it seems that we are mis-calculating the range covered by the data variable. For a normal data variable, e.g., an integer, things work fine.

xusheng6 avatar Aug 02 '24 10:08 xusheng6

This only sees to hurt string data variable, I briefly looked into it and it seems that we are mis-calculating the range covered by the data variable. For a normal data variable, e.g., an integer, things work fine.

This is actually not the case -- we are missing all such updates if the data variable is an auto one. If it is a user one, then it works just fine

xusheng6 avatar Aug 27 '24 07:08 xusheng6