HLIL shouldn't propagate string constants from read/write data

[whitequark]

Version and Platform (required):

• Binary Ninja Version: 4.1.5261-dev Personal (859dedd4)

Bug Description: HLIL will sometimes replace a writable data variable that contains a string with the value of the string.

Steps To Reproduce: I believe this is enough:

Expected Behavior: HLIL displays the assignment as data_1800b6088[0] = 0 or something.

HLIL displays the read (rcx_1 = ...) as rcx_1 = *data_1800b6088 or something.

[xusheng6]

@whitequark could you please provide with us a binary that can reproduce this? I know similar binaries are not too hard to find, but it would save us some time on it. You can ping us on slack if you would like to

[whitequark]

@xusheng6 I'll upload a binary soon, it's public.

[whitequark]

Here's the binary: SSEdevice.zip