binaryninja-api icon indicating copy to clipboard operation
binaryninja-api copied to clipboard

Create structure dialog should offer to create a vtable

Open xusheng6 opened this issue 9 months ago • 4 comments

Right now, when we wish to create a class and its vtable, we need to do them separately. There should be a way to combine these operations

xusheng6 avatar May 09 '24 08:05 xusheng6

Related, the types view should also offer to create a vtable at the selected offset

xusheng6 avatar May 09 '24 09:05 xusheng6

Sometimes it's not just a single vtable, how do you propose cases of multiple inheritance be handled? Currently it's inconvenient to go through and define the vtable when there's only one, but it really becomes a hassle when there are multiple.

ExecuteProtect avatar May 09 '24 14:05 ExecuteProtect

Sometimes it's not just a single vtable, how do you propose cases of multiple inheritance be handled? Currently it's inconvenient to go through and define the vtable when there's only one, but it really becomes a hassle when there are multiple.

I suggested to add a context menu in the types view that can create a vtable at the current offset. Do you think it will work? I think it would also be helpful for the case when you initially forget to create the vtable, and decide to add one later

xusheng6 avatar May 09 '24 15:05 xusheng6

Sometimes it's not just a single vtable, how do you propose cases of multiple inheritance be handled? Currently it's inconvenient to go through and define the vtable when there's only one, but it really becomes a hassle when there are multiple.

I suggested to add a context menu in the types view that can create a vtable at the current offset. Do you think it will work? I think it would also be helpful for the case when you initially forget to create the vtable, and decide to add one later

Yeah, I think that would be quite helpful if implemented that way.

ExecuteProtect avatar May 09 '24 16:05 ExecuteProtect