binaryninja-api icon indicating copy to clipboard operation
binaryninja-api copied to clipboard

Import Type by GUID only works on lowercase

Open CouleeApps opened this issue 1 year ago • 0 comments

Version and Platform (required):

  • Binary Ninja Version: 4.0.4854-dev
  • OS: macOS
  • OS Version: 14
  • CPU Architecture: M1

Bug Description: I tried to import a type by GUID in the format that microsoft gave me, but it seems only lowercase alpha works. For reference, I grabbed the GUID from https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-wmi/18c8f1a1-652f-43b7-9186-6098bc303a8d as {44ACA674-E8FC-11D0-A07C-00C04FB68820}. But in order for the import to work, I had to strip the {} and make the letters lowercase. It would be nice if I could paste guids directly from microsoft into the guid importer.

Steps To Reproduce: Please provide all steps required to reproduce the behavior:

  1. Open windows binary
  2. Go to type browser
  3. Import type by GUID
  4. Enter {44ACA674-E8FC-11D0-A07C-00C04FB68820}
  5. Observe error message
  6. Enter 44aca674-e8fc-11d0-a07c-00c04fb68820
  7. Observe success
  8. Feel sad

Expected Behavior: I wanted the first string to work too

CouleeApps avatar Feb 09 '24 22:02 CouleeApps