binaryninja-api icon indicating copy to clipboard operation
binaryninja-api copied to clipboard

DataVariable type references not properly updated after undefining child types

Open op2786 opened this issue 1 year ago • 1 comments

Version and Platform (required):

  • Binary Ninja Version: 4.0.4836-dev, df4290fd
  • OS: macos
  • OS Version: 14.3
  • CPU Architecture: arm64

Steps To Reproduce:

  1. Open the attached binary

  2. Navigate to adress 100007a53

  3. Select two lines and create a structure using the S shortcut to generate a dummy structure named struct_1

  4. Convert that structure to a structure array with two items You should get something like:

  5. Open types sidebar and undefine struct_1

  6. Observe the crash

Additional Information: ls.zip

op2786 avatar Feb 07 '24 13:02 op2786

I pushed a fix for this crash but it points to a larger issue that needs to be handled, were we're not properly fixing up the data variable afterward. I'm going to change this other problem.

plafosse avatar Feb 07 '24 14:02 plafosse