binaryninja-api icon indicating copy to clipboard operation
binaryninja-api copied to clipboard

Experimental types sidebar loses focus after an undo operation

Open op2786 opened this issue 2 years ago • 1 comments

Version and Platform (required):

  • Binary Ninja Version: 3.6.4707-dev Personal, 3cd0ac3b
  • OS: macos
  • OS Version: 14.1
  • CPU Architecture: arm64

Bug Description: See the GIF please.

Steps To Reproduce:

  • Open a structure in types sidebar
  • Undefine one of its members
  • Undo the undefination with CTRL + Z
  • See it is focused on the linear view

Expected Behavior: I expect it to stay focused on where I was before undo.

Screenshots:

Recording 2023-12-07 at 11 50 13

op2786 avatar Dec 07 '23 09:12 op2786

This is actually present in all sidebar widgets, since the navigation system only understands locations in main view areas, so undoing an operation (which causes navigation) will focus the main view instead. Fixing this correctly will involve a rewrite of the navigation/location system, or a bunch of hacks to handle type view specifically.

CouleeApps avatar Dec 28 '23 02:12 CouleeApps