binaryninja-api icon indicating copy to clipboard operation
binaryninja-api copied to clipboard

Better discoverability of parser error on Change Type dialog

Open op2786 opened this issue 3 years ago • 1 comments

The error message that appears when changing function prototypes should be more understandable.

For example when I try to apply function prototype for DllMain function as BOOL __stdcall DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved), it says "Error parsing specified type" but it is not clear what is wrong with it. In this example DWORD and LPVOID is unknown to BN. Modifying structures is different in a way that it shows exactly what is wrong about definition.

op2786 avatar Jul 20 '22 07:07 op2786

It's not easily discoverable, but if you mouse over the error text in the type dialog, the tooltip will have a more descriptive error message from the parser. Changing this issue to be about displaying that in a better manner image

CouleeApps avatar Jul 20 '22 19:07 CouleeApps