binaryninja-api icon indicating copy to clipboard operation
binaryninja-api copied to clipboard

Broken shadow painting behind command palette affects linear view header box

Open galenbwill opened this issue 3 years ago • 1 comments

Version and Platform (required):

  • Binary Ninja Version: since forever, according to rusty
  • OS: macOS
  • OS Version: ¯\_(ツ)_/¯

Bug Description:

Steps To Reproduce:

  1. scroll to the top of the binary so the Linear View header is visible
  2. open the command palette, observe black bars: image
  3. close the command palette, observe black bars are still there: image
  4. click in the offending space in the header, observe the header gets repainted (scrolling also works): image

Additional Information: Note that it happens upon both opening and closing the palette -- scrolling while the palette is open will clear the bars, but closing the palette will make them appear again.

galenbwill avatar Feb 05 '22 00:02 galenbwill

I guess this also is related. Notice the shadow in feature map.

shadow

op2786 avatar Aug 04 '22 08:08 op2786

This was happening because it drew the rect in the repainted region, which was just the region covered by command palette (and its shadow), so the painting assumed that the rect only extended that far. Fixed as of 3.2.3799.

CouleeApps avatar Oct 22 '22 22:10 CouleeApps