binaryninja-api icon indicating copy to clipboard operation
binaryninja-api copied to clipboard

Highlight Block does not propagate to HLIL

Open gaasedelen opened this issue 4 years ago • 1 comments

Binary Ninja Version

2.4.2921-dev

Describe the bug

No block-based highlights propagate to the HLIL view.

To Reproduce

Steps to reproduce the behavior:

  1. Highlight all the blocks in a function
  2. View the HLIL for the function
  3. None of the HLIL is highlighted in the function

Expected behavior

If I highlight blocks of instructions, I would expect these highlights to propagate to the HLIL. At least, in the same manner that individual instruction highlights currently propagate

Screenshots

This GIF demonstrates the issue:

highlight_binja_blocks

Version and Platform (required):

  • Binary Ninja: Dev 2.4.2921
  • OS: Windows
  • Version: Windows 8.1 (x64)

Additional context

N/A

gaasedelen avatar Aug 09 '21 18:08 gaasedelen

Not sure if this is true but is this issue the reason why Lighthouse isn't working on HLIL?

elbiazo avatar Sep 22 '22 04:09 elbiazo

Not sure if this is true but is this issue the reason why Lighthouse isn't working on HLIL?

Yes.

Lighthouse does block-based highlighting in Binja because it is significantly faster to highlight thousands of blocks rather than millions of individual instructions. That said, Lighthouse is still much slower in Binja than IDA.

While it would be nice for this issue to be fixed, the ideal solution for Lighthouse would be a rendering callback that plugins could use from Binary Ninja to decide whether or not an instruction should be highlighted as it comes into view.

gaasedelen avatar Sep 23 '22 19:09 gaasedelen