Nick Hodgskin
Nick Hodgskin
There is testing in the sense of importing the datasets (which is good, so we know that the datasets construct). The tooling `compare_datasets` is just to compare the metadata of...
It also looks like as part of compatibility with v3 we have `Field.lon` and `Field.lat` and `Field.depth` - these can also go as part of this PR - there are...
let me know if any part of that is unclear
@clementbricaud it would be really helpful if we could see the code that you are running. Would you be able to copy/paste your full script here so that we can...
Hi @clementbricaud , this is not the _full_ script (i.e., the script from top to bottom, or in the case of a notebook - the code from all the cells)....
> So what is the plan here? Should we just merge this and see if it works, and then fix any issues? Sounds good. Any particular issues that you're concerned...
> * no particle interaction kernels (will open an issue for this when a PR for this issue is created) Re-iterating something mentioned [by Ryan Abernathey at Scipy 2019](https://youtu.be/QKSbbi_67Ro?si=pH8TuzTKZ2BSOhBK&t=1644), I...
That if we have simulations with no particle particle interaction, its quite parallelizable allowing us to scale up horizontally by deploying more instances and partitioning the particleset across the instances.
Pydantic has a rich system for validation, so I recommend we work inside that https://docs.pydantic.dev/latest/concepts/validators/#before-after-wrap-and-plain-validators.
I should have explained better in the original description. It was close to end of day when I made this so it was a bit rushed :) . Most of...