Quark icon indicating copy to clipboard operation
Quark copied to clipboard

Log spam - Creative tab loop found when adding Block{quark:monster_box} next to Block{minecraft:spawner}

Open sciguyryan opened this issue 4 months ago • 9 comments

Hi.

While putting together a mod pack I noticed the following appearing a lot in my logs.

[18:44:05] [Render thread/WARN] [zeta/]: Creative tab loop found when adding Block{quark:monster_box} next to Block{minecraft:spawner}

It doesn't seem like it's intended to do that and something has clearly gone wrong, though nothing is amiss as far as I can see. I figured it's worth reporting just in case. If nothing else it causes a fair amount of log spam.

I've reported it here because Zeta is specifically cited in the warning, but it might be a Quark issue. I'm not certain.

sciguyryan avatar Feb 19 '24 18:02 sciguyryan

I'm also experiencing this (seems intermittent?) and it results in entire creative tabs vanishing from the menu. Here is a copy of my log from it occuring in my modpack: https://mclo.gs/lDVsVIk ~~I suspect it may be trigged from Copycats+ performing on-demand rebuilding of creative tabs for their feature config.~~ EDIT: I was able to reproduce without Copycats+: https://mclo.gs/Z504Kqb

ChloeDawn avatar Feb 22 '24 19:02 ChloeDawn

Copycats+

It's definitely not Copycats+ in my case since I'm not using it in my pack. Nice to see someone else has spotted this too though!

sciguyryan avatar Feb 22 '24 19:02 sciguyryan

Forge 1.20.1 https://gist.github.com/Krimatoria/67b12b73a06d7c02cd86a1210a9f99fe - Log

[19:36:37] [Thread-45/WARN] [zeta/]: Creative tab loop found when adding Block{quark:monster_box} next to Block{minecraft:spawner} java.lang.RuntimeException: Creative tab placement misses exceeded failsafe, aborting logic at TRANSFORMER/[email protected]/org.violetmoon.zeta.registry.CreativeTabManager.buildContents(CreativeTabManager.java:141) at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:260) at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:252) at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) at LAYER PLUGIN/[email protected]/net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:114) at LAYER PLUGIN/[email protected]/net.minecraftforge.fml.ModLoader.lambda$postEvent$29(ModLoader.java:326) at java.base/java.lang.Iterable.forEach(Unknown Source) at LAYER PLUGIN/[email protected]/net.minecraftforge.fml.ModList.forEachModInOrder(ModList.java:227) at LAYER PLUGIN/[email protected]/net.minecraftforge.fml.ModLoader.postEvent(ModLoader.java:326) at TRANSFORMER/[email protected]/net.minecraftforge.common.ForgeHooks.onCreativeModeTabBuildContents(ForgeHooks.java:1633) at TRANSFORMER/[email protected]/net.minecraft.world.item.CreativeModeTab.m_269498_(CreativeModeTab.java:129) at TRANSFORMER/[email protected]/net.minecraft.world.item.CreativeModeTabs.m_268957_(CreativeModeTabs.java:1696) at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source) at java.base/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source) at java.base/java.util.Iterator.forEachRemaining(Unknown Source) at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Unknown Source) at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source) at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source) at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source) at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source) at java.base/java.util.stream.ReferencePipeline.forEach(Unknown Source) at TRANSFORMER/[email protected]/net.minecraft.world.item.CreativeModeTabs.m_269421_(CreativeModeTabs.java:1695) at TRANSFORMER/[email protected]/net.minecraft.world.item.CreativeModeTabs.m_269226_(CreativeModeTabs.java:1710) at TRANSFORMER/[email protected]+1.20.1+forge/dev.emi.emi.registry.EmiStackList.reload(EmiStackList.java:62) at TRANSFORMER/[email protected]+1.20.1+forge/dev.emi.emi.runtime.EmiReloadManager$ReloadWorker.run(EmiReloadManager.java:173) at java.base/java.lang.Thread.run(Unknown Source)

Krimatoria avatar Mar 04 '24 17:03 Krimatoria

Also experiencing significant issues with this bug. It completely hides the contents of entire creative tabs.

BigPhobos avatar Mar 08 '24 08:03 BigPhobos

Experiencing this as well

3ncanis avatar Mar 26 '24 15:03 3ncanis

I think this is related to Every Compat somehow - I had the exact same error (and missing torches in JEI along with other items), and removing Every Compat solved the issue.

Needs more testing, but just in case!

Edit: Never mind, error still being thrown (but items returned)

kaebiene avatar Apr 07 '24 13:04 kaebiene

Seems to be just any mod that adds a lot of new items/blocks from what I can tell, if I make Supplementaries go into it's own creative tab it happens less but still occasionally does.

3ncanis avatar Apr 07 '24 15:04 3ncanis

I added some debugging tools to the config. If you can still reproduce this in the next version please reach out to me on discord.

Vazkii avatar Apr 09 '24 10:04 Vazkii

Looks like this is still happening. Version 1.0-16 should have more options to test.

I personally have never managed to reproduce this issue, so here's some points I think could be good to try and figure it out:

  • If "Force Creative Tab Appends" is enabled in the Zeta config, can the issue still happen? (This proved true in @3ncanis's instance)
  • What does the log output if "Enable Creative Verbose Logging" is enabled? (note: this will output a very large file and may crash your launcher if it's trying to pretty-print it)

Asking for anyone who can reproduce this to reach out on discord as well so we can try and track it down, thank you.

Vazkii avatar Apr 11 '24 18:04 Vazkii