Quark icon indicating copy to clipboard operation
Quark copied to clipboard

[1.18.2] Backpack preventing shift-clicking recipes into inventory

Open FynnWaelsing opened this issue 3 years ago • 7 comments

Quark: 3.2-346 Oddities: 1.18 ARL: 1.7-53 Forge: 40.0.32

When you are wearing the Quark backpack, attempting to shift-click multiple instances of a recipe from the inventory crafting screen into the inventory results in just one item being made and the recipe result being removed from the screen (as shown here): 2022-03-27_16 49 25

FynnWaelsing avatar Mar 27 '22 20:03 FynnWaelsing

Strange. I can't reproduce it with only Quark. does it still happen if you empty your inventory into a chest, have nothing but the backpack, and try again?

yrsegal avatar Mar 28 '22 23:03 yrsegal

Sorry, just now saw this. I'll test and let you know

FynnWaelsing avatar Apr 09 '22 18:04 FynnWaelsing

WIth my current batch of mods installed along with Quark it still happens, even with an entirely empty inventory except for the backpack. Might take me a while to narrow down what cross-mod interaction is causing this

FynnWaelsing avatar Apr 09 '22 18:04 FynnWaelsing

I found the mod that causes this bug: FastWorkbench

Forge 40.1.20 Quark 3.2-356 QuarkOddities 1.18 AutoRegLib 1.7-53 FastWorkbench 1.18.2-6.0.2 Placebo 1.18.2-6.4.0

Video demonstration:

https://user-images.githubusercontent.com/11332249/169549222-753cc991-9e09-4e1c-85a6-c852b012c287.mp4

MaoDoBan avatar May 20 '22 14:05 MaoDoBan

Interesting... Does quark do anything to the result slot?

Shadows-of-Fire avatar May 20 '22 14:05 Shadows-of-Fire

Ah, I think this is the problem - the backpack menu is an extension of InventoryMenu, so my custom result slot is applied, but there's an override on quickMoveStack here which means that this mixin is failing. I might have to add a second mixin to the backpack menu to make that be called...

Shadows-of-Fire avatar May 20 '22 14:05 Shadows-of-Fire

Fixed in FWB 6.1.0, and i think it works better than Quark's base shift-click-craft handling :p

https://user-images.githubusercontent.com/3682588/184058675-2bf30598-ace3-4782-9c0d-fab6763d8bfa.mp4

Shadows-of-Fire avatar Aug 11 '22 03:08 Shadows-of-Fire