Botania icon indicating copy to clipboard operation
Botania copied to clipboard

Shader mods conflict with Botania's own usage of shaders, leading to missing renders

Open Ninlives opened this issue 3 years ago • 19 comments

Mod Loader

Fabric

Minecraft Version

1.18.1

Botania version

Botania-1.18.1-427-FABRIC

Modloader version

Fabric: Loader 0.12.12 + API 0.46.1

Modpack info

No response

The latest.log file

https://gist.github.com/Ninlives/9e0db834a95fc471eaa7ac3ffd50a404

Issue description

  1. Sparks are invisible.
  2. Mana Pools are always look like they are empty.
  3. Part of Mana Pylon is invisible.

Pylon

ManaPool

Steps to reproduce

  1. Launch the game.
  2. Place a Mana Pool and fill it with some mana.
  3. Place a Spark.
  4. Place a Mana Pylon.
  5. Enable any shaderpack.
  6. Texture disappears.

Other information

Iris version: mc1.18.1-1.2.0-pre Sodium version: fabric-mc1.18.1-0.4.0-alpha6+build.14

Ninlives avatar Feb 11 '22 12:02 Ninlives

Known, see #3912 and https://github.com/IrisShaders/Iris/issues/194 Working around this is planned at some point.

Hubry avatar Feb 14 '22 18:02 Hubry

Known, see #3912 and IrisShaders/Iris#194 Working around this is planned at some point.

Great to know, thanks for your work!

Ninlives avatar Feb 15 '22 00:02 Ninlives

This issue is stale because it has been open for a while with no activity. Remove stale label or comment or this will be closed soon.

github-actions[bot] avatar Apr 17 '22 00:04 github-actions[bot]

This issue is stale because it has been open for a while with no activity. Remove stale label or comment or this will be closed soon.

Still important to me.

Ninlives avatar Apr 19 '22 01:04 Ninlives

I would love to see a fix for this, the crafting halo is also affected by this.

DonFlymoor avatar May 12 '22 14:05 DonFlymoor

Having the issue using Sildur's shaders. I tried two different shader packs. Issue only goes away when disabling shaders...

2022-06-07_11 52 18

drharlow avatar Jun 07 '22 15:06 drharlow

I have one piece of info to add...

It seems the textures don't actually disappear. They're just rendered in the wrong place, and at the wrong (tiny) scale.

For me it always renders in the center left of my screen, like this:

botania_rendering_full

I drew the red arrow for emphasis. It shows up more easily against a light background.

Zooming way in, you can (sorta) see the individual mana pools, sparks and pylons:

botania_rendering_zoom

I drew red boxes to show how it matches my layout of mana pools.

And it doesn't rotate as my character view rotates. It's always oriented as if I was facing directly north, and it shifts around a little depending on which chunk I'm standing in.

This is on minecraft 1.18.2, All of Fabric 5 v1.2.4, Iris 1.2.4-build.38, BSL shaders v8.1.02.3.

Infinoid avatar Jun 28 '22 01:06 Infinoid

Having the issue using Sildur's shaders.

@drharlow, I think you're seeing something similar to the rendering I described above... in your screenshot, it is to the left of the mana pools' bottom left corner. Would you be able to confirm?

Infinoid avatar Jun 28 '22 01:06 Infinoid

Any progress here? :P

Ninlives avatar Jul 22 '22 11:07 Ninlives

No

williewillus avatar Jul 22 '22 16:07 williewillus

I tried using the option to turn off Botania's shaders, but no dice. Hope there is a fix at some point soon :)

KaniGoat avatar Aug 04 '22 15:08 KaniGoat

that option got removed in the 1.17 updates. I'll probably reintroduce it in some form.

williewillus avatar Aug 04 '22 15:08 williewillus

Just noticed this issue on 1.18.2 forge using rubidium, oculus and complementary shaders. Absolutely love the mod, and have it on my new server.

Wraen avatar Oct 31 '22 16:10 Wraen

A temporary alternative is to use Canvas fabrcimod to load the shaderpacks,which means sodium,iris and BSL,SEUS etc cannot be used.btw my save crashed because of the infliction between canvas and tconstruct...

Mreblack avatar Nov 09 '22 03:11 Mreblack

@williewillus Is there any assistance that can be provided for a fix for this to be worked on? 🙂

connorhsm avatar Nov 12 '23 04:11 connorhsm

@connorhsm the useShaders option was reintroduced in 1.19.2-440 and can be disabled to fix this. There's probably not much else that can be done. Due to time limitations the option probably won't be backported, but if anyone wants to rebase the patch and build it themselves here's the commit 3658e489a88e61ba2d45ae7d730a966795392290

williewillus avatar Nov 22 '23 16:11 williewillus

@williewillus Could you please provide details on a definitive way to disable shaders for Botania?

Most information I can find is outdated and doesn't line up to what I'm seeing in the config files I have for Botania being used in the AoF6 pack. The best answer I have found is from the author of the Shaders I'm using here.

If you have the "Botania" mod: Open the mod config file, set "B:fancySkybox.enable" AND "B:shaders.enabled" to "false".

The B:shaders.enabled setting is not present in either of the config files. Adding it and restarting has not shown any difference.

I have confirmed the pack is using Botania 1.19.2-440.

connorhsm avatar Nov 26 '23 07:11 connorhsm

@connorhsm I'm not willie but I'm definitely seeing a config option in the botania_client.json to disable shaders:

image

What I'd suggest is deleting your config and redownloading Botania, it should definitely be there. (for the record this was with 1.19.2-440 Fabric also).

anoomolu avatar Nov 28 '23 08:11 anoomolu

@anoomolu Thanks for the suggestion. I deleted the botania-client.json config file and reloaded my mod pack. The config was successfully regenerated with the shaders setting that was earlier missing.

I imagine this is simply what the All of Fabric 6 pack must be shipping as default, thanks both for your time.

connorhsm avatar Nov 28 '23 09:11 connorhsm